Fix time unit for process_cpu_seconds_total #881

Signed-off-by: Fabian Stäber <fabian@fstab.de>
prometheus · Oct 22, 2023 · ca75666 · ca75666
1 parent 18bdc33
commit ca75666
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...mentation-jvm/src/main/java/io/prometheus/metrics/instrumentation/jvm/ProcessMetrics.java b/...mentation-jvm/src/main/java/io/prometheus/metrics/instrumentation/jvm/ProcessMetrics.java
@@ -94,7 +94,7 @@ private void register(PrometheusRegistry registry) {
                         // through implemented interfaces until the method can be made accessible and invoked.
                         Long processCpuTime = callLongGetter("getProcessCpuTime", osBean);
                         if (processCpuTime != null) {
-                            callback.call(Unit.millisToSeconds(processCpuTime));
+                            callback.call(Unit.nanosToSeconds(processCpuTime));
                         }
                     } catch (Exception ignored) {
                     }

diff --git a/...ation-jvm/src/test/java/io/prometheus/metrics/instrumentation/jvm/ProcessMetricsTest.java b/...ation-jvm/src/test/java/io/prometheus/metrics/instrumentation/jvm/ProcessMetricsTest.java
@@ -11,6 +11,7 @@
 import java.io.File;
 import java.io.IOException;
 import java.lang.management.RuntimeMXBean;
+import java.util.concurrent.TimeUnit;
 
 import static io.prometheus.metrics.instrumentation.jvm.TestUtil.convertToOpenMetricsFormat;
 import static org.mockito.ArgumentMatchers.any;
@@ -29,7 +30,7 @@ public class ProcessMetricsTest {
 
     @Before
     public void setUp() throws IOException {
-        when(sunOsBean.getProcessCpuTime()).thenReturn(72L);
+        when(sunOsBean.getProcessCpuTime()).thenReturn(TimeUnit.MILLISECONDS.toNanos(72));
         when(sunOsBean.getOpenFileDescriptorCount()).thenReturn(127L);
         when(sunOsBean.getMaxFileDescriptorCount()).thenReturn(244L);
         when(runtimeBean.getStartTime()).thenReturn(37100L);