Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process_cpu_seconds_total should be scaled from nano's, not milli's #881

Closed
yrn1 opened this issue Oct 20, 2023 · 1 comment
Closed

process_cpu_seconds_total should be scaled from nano's, not milli's #881

yrn1 opened this issue Oct 20, 2023 · 1 comment

Comments

@yrn1
Copy link

yrn1 commented Oct 20, 2023

In io.prometheus.metrics.instrumentation.jvm.ProcessMetrics, the value returned from callLongGetter("getProcessCpuTime", osBean) is in nanoseconds, but is scaled with Unit.millisToSeconds(processCpuTime)
fstab added a commit that referenced this issue Oct 22, 2023
@fstab
Fix time unit for process_cpu_seconds_total #881
ca75666 
Signed-off-by: Fabian Stäber <fabian@fstab.de>
@fstab fstab mentioned this issue Oct 22, 2023
Merged
fstab added a commit that referenced this issue Oct 22, 2023
@fstab
Fix time unit for process_cpu_seconds_total #881
6843727 
Signed-off-by: Fabian Stäber <fabian@fstab.de>
@fstab
Copy link
Member

fstab commented Oct 22, 2023

Thanks a lot! Fixed in #882.

@fstab fstab closed this as completed Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fstab @yrn1