Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix time unit for process_cpu_seconds_total #881 #882

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

fstab
Copy link
Member

@fstab fstab commented Oct 22, 2023

Fixes the bug reported in #881:

In io.prometheus.metrics.instrumentation.jvm.ProcessMetrics, the value returned from callLongGetter("getProcessCpuTime", osBean) is in nanoseconds, but is scaled with Unit.millisToSeconds(processCpuTime)

Signed-off-by: Fabian Stäber <fabian@fstab.de>
@fstab fstab merged commit 6843727 into main Oct 22, 2023
@fstab fstab deleted the process_cpu_seconds_total branch October 22, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant