Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change white/blacklist naming convention #527

Closed

Conversation

richardbadman
Copy link

This is just a small PR to change the naming convention of two variables that are used within this repository, coming from a diversity and inclusion point of view, the proposed changes in this PR don't have negative racial historic connotations attached with them.

I have also tested this working on a tiny HBase cluster of 4 machines

Signed-off-by: Richard Goodman <richardg@brandwatch.com>
@brian-brazil
Copy link
Contributor

Thanks for your PR. Changing these names is on the cards, however it is a breaking change in a widely used tool. There is interest and someone in the community who said they were working on expanding these particular options to work on not just the object names but also the attribute names, which would also be a breaking change. Accordingly to minimise disruption to end users, I want to combine breaking changes as much as is possible, and have this altered as part of that functionality expansion rather than breaking the same config fields twice in a row.

Also I think processed/ignored would make more sense here, as we're not allowing/denying anything.

@richardbadman
Copy link
Author

Thanks for the feedback, with that in mind, should I close this PR in favour of word going on elsewhere that someone is working on?

@brian-brazil
Copy link
Contributor

Let's leave it open in case anyone else is wondering, as while it has always been the plan it wasn't written down until now.

@dhoard
Copy link
Collaborator

dhoard commented Jul 22, 2023

I have a draft PR #852 in progress for this change.

Existing configurations using whitelistObjectNames and blacklistObjects will continue to work, but we should consider them deprecated.

@dhoard
Copy link
Collaborator

dhoard commented Aug 8, 2023

Closing. Implemented and merged changes.

@dhoard dhoard closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants