Refactored outdated terms #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fstab
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Thanks for that Doug, I like it, especially the fact that we still support the old names for backwards compatibility.
One thought: I had to read the names allowlistObjectNames and denylistObjectNames twice, my first intuition was that it's about allowing listing object names. What do you think of calling it includedObjectNames and excludedObjectNames?
|
Totally agree! (was just trying to be consistent.) I'll make the change. |
Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
dhoard
force-pushed
the
refactor-outdated-terms
branch
from
df42ec7
to
b882937
Compare
dhoard
added a commit
that referenced
this pull request
Jul 29, 2023
Signed-off-by: Doug Hoard <doug.hoard@gmail.com>
s-rwe
added a commit
to s-rwe/jmx_exporter
that referenced
this pull request
Oct 23, 2023
Signed-off-by: Ralph Weires <r.weires@sedai.lu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed code and documentation to use
allowlistObjectNamesanddenylistObjectNamesin lieu ofwhitelistObjectNamesandblacklistObjectNames