Fix issue with histogram rendering #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out, `makeBuckets` always returns at least the +Inf bucket. So a native histogram will never be rendered. The canonical way of marking a native histogram, even one without any observations yet, is to have at least one span. With this commit, a native histogram is rendered if there is at least one span. Otherwise, a classic histogram is rendered. Signed-off-by: beorn7 <beorn@grafana.com>
Signed-off-by: beorn7 <beorn@grafana.com>
jan--f
approved these changes
Jul 11, 2024
|
In PGW, we are rendering both types of buckets in case both exist, so that should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out,
makeBucketsalways returns at least the +Infbucket. So a native histogram will never be rendered. The canonical
way of marking a native histogram, even one without any observations
yet, is to have at least one span.
With this commit, a native histogram is rendered if there is at least
one span. Otherwise, a classic histogram is rendered.
I have also made the documentation a bit more explicit about this and re-added a classic histogram example.