Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with histogram rendering #175

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Fix issue with histogram rendering #175

merged 2 commits into from
Jul 11, 2024

Commits on Jul 10, 2024

  1. Invert detection logic for native histograms 

    As it turns out, `makeBuckets` always returns at least the +Inf
bucket. So a native histogram will never be rendered. The canonical
way of marking a native histogram, even one without any observations
yet, is to have at least one span.

With this commit, a native histogram is rendered if there is at least
one span. Otherwise, a classic histogram is rendered.

Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4a68a11 View commit details
    Browse the repository at this point in the history

  2. Improve histogram documentation 

    Signed-off-by: beorn7 <beorn@grafana.com>
    @beorn7
    beorn7 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    472bd39 View commit details
    Browse the repository at this point in the history