chore(account): use Environment object
#2734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szkl
force-pushed
the
chore/account/nodes/email
branch
from
280f1a8
to
330d371
Compare
szkl
force-pushed
the
chore/account/nodes/email
branch
from
330d371
to
dd30108
Compare
| @@ -102,7 +104,7 @@ export async function createContext( | |||
| env: Environment | |||
| ) { | |||
| const { req } = opts | |||
| const contextInner = await createContextInner({ ...opts, ...env }) | |||
| const contextInner = await createContextInner({ ...opts, ...env, env }) | |||
There was a problem hiding this comment.
The ...env, env bit doesn't look right. Was the intent to replace all env vars that were part of ctx before with a dedicated prop called env?
There was a problem hiding this comment.
Oh, no. I actually wanted to keep the changes in this pull request minimal so I didn't make any changes to the existing interface and keep it compatible with the rest. I can fix the rest in a post-feature-follow-up request.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Emailaccount node can be used out oftRPCruntime wherecontextobject is not available and not possible to construct. Thenode class implementations do not have access to
tRPCstack,anyway. This is the first change to replace the
tRPCcontext objectinterface in node class definitions.
This specific change is a dependency for the development branch of #2415.
Testing
Checklist