Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(platform): use Environment object as an individual entity #2739

Merged
merged 2 commits into from
Oct 24, 2023
Merged

chore(platform): use Environment object as an individual entity #2739

merged 2 commits into from
Oct 24, 2023

Conversation

szkl
Copy link
Contributor

@szkl szkl commented Oct 23, 2023

Description

This change sets the environment object as an individual property in
the tRPC context object and updates all the references to that
property.

Related Issues

Testing

  • Manual

Checklist

  • I have read the CONTRIBUTING guidelines
  • I have tested my code (manually and/or automated if applicable)
  • I have updated the documentation (if necessary)

@szkl szkl self-assigned this Oct 23, 2023
@szkl szkl marked this pull request as draft October 23, 2023 12:09
@szkl szkl force-pushed the chore/platform/environment branch 3 times, most recently from 47a861b to dabb73f Compare October 23, 2023 14:03
@szkl
Copy link
Contributor Author

szkl commented Oct 23, 2023

The initial pull request was #2734

@szkl szkl force-pushed the chore/platform/environment branch from dabb73f to 2e3c1b9 Compare October 23, 2023 14:08
@szkl szkl marked this pull request as ready for review October 23, 2023 14:08
Cosmin-Parvulescu
Cosmin-Parvulescu suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@Cosmin-Parvulescu Cosmin-Parvulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When inviting a person to a group, using an e-mail address, I get the following error:
image

@szkl szkl force-pushed the chore/platform/environment branch from 2e3c1b9 to 6013865 Compare October 23, 2023 19:49
@szkl szkl force-pushed the chore/platform/environment branch 2 times, most recently from 78a7eb4 to 9238f6f Compare October 23, 2023 23:46
@szkl szkl force-pushed the chore/platform/environment branch from 9238f6f to 5091c56 Compare October 24, 2023 03:19
@szkl szkl merged commit bd84c14 into main Oct 24, 2023
12 checks passed
@szkl szkl deleted the chore/platform/environment branch October 24, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosmin-Parvulescu Cosmin-Parvulescu Cosmin-Parvulescu approved these changes

@betimshahini betimshahini Awaiting requested review from betimshahini

Assignees

@szkl szkl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szkl @Cosmin-Parvulescu