Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server support for chroma #66

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ristomcgehee
Copy link
Contributor

@ristomcgehee ristomcgehee commented Oct 29, 2023

Before this PR can be merged it needs:

@ristomcgehee ristomcgehee marked this pull request as draft October 29, 2023 23:38
@ristomcgehee ristomcgehee changed the title Chroma vector store server Add server support for chroma Oct 29, 2023
@seanpmorgan
Copy link
Member

@ristomcgehee I'll publish 0.1.0 once we have a minimal test for chromadb SDK instantiation and querying. If you'd like to PR that lmk

@ristomcgehee
Copy link
Contributor Author

@ristomcgehee I'll publish 0.1.0 once we have a minimal test for chromadb SDK instantiation and querying. If you'd like to PR that lmk

@seanpmorgan Yeah, I can make a PR for that. I'll be traveling for work all next week, so it might be a couple weeks till I get to it if that's all right. Since Chroma doesn't have a hosted version, should we spin up a Chroma server before running the tests, maybe with Docker Compose?

@seanpmorgan
Copy link
Member

0.1.0 published:
https://www.npmjs.com/package/rebuff

@ristomcgehee ristomcgehee force-pushed the chroma-vector-store-server branch from 63a3829 to 59f44a1 Compare December 6, 2023 05:37
@ristomcgehee ristomcgehee marked this pull request as ready for review December 6, 2023 05:38
@ristomcgehee
Copy link
Contributor Author

@seanpmorgan ready to be reviewed/merged

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks! Apologies for the delay on review

@seanpmorgan seanpmorgan merged commit bd8916f into protectai:main Jan 16, 2024
2 checks passed
ristomcgehee added a commit to ristomcgehee/rebuff that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants