Add chroma tests #84
Merged
Add chroma tests #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
seanpmorgan
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks @ristomcgehee ! Small refactor requested for how we instantiate the tests. Otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some basic tests for using Chroma as the vector store.
I pinned
chromadbto1.5.6because I encountered the same issue as langchain-ai/langchain#7260 on later versions.I considered introducing Docker Compose since I'm running Chroma as a container, but I didn't think the project was quite complicated enough yet to merit Docker Compose.