io_win32: support non-ASCII paths #4013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use "googletest.h", apprently that leads to linking errors on Windows which I couldn't figure out how to solve, and decided to just go with plain gTest instead. See protocolbuffers#3951
If the test cannot find a temp directory by checking environment variables, it will fall back to using the current working directory as the temp directory root. This is what the test used to do as of commit protocolbuffers@6de51ca and what was then changed by commit protocolbuffers@792d098
Unlike GetEnvironmentVariableW, GetCurrentDirectoryW doesn't set ERROR_INSUFFICIENT_BUFFER.
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Thank you @pherl ! Do I have to create a separate PR on master, or will you or someone cherrypick these on top of master? |
|
No problem. I will just merge 3.5.x into master.
…On Thu, Dec 7, 2017 at 11:04 PM László Csomor ***@***.***> wrote:
Thank you @pherl <https://github.com/pherl> ! Do I have to create a
separate PR on master, or will you or someone cherrypick these on top of
master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4013 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATQyVBrIfRB0aAbtu38VdbbAj3zKJp8ks5s-N97gaJpZM4Q5pJv>
.
|
|
Great, thank you @pherl ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3951
Forked from #3978 per @pherl 's request #3978 (comment)