Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io_win32: support non-ASCII paths #4013

Merged
merged 6 commits into from
Dec 7, 2017
Merged

io_win32: support non-ASCII paths #4013

merged 6 commits into from
Dec 7, 2017

Commits on Dec 7, 2017

  1. io_win32_unittest: make //:win32_test run again 

    Do not use "googletest.h", apprently that leads to
linking errors on Windows which I couldn't figure
out how to solve, and decided to just go with
plain gTest instead.

See protocolbuffers#3951
    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    953a025 View commit details
    Browse the repository at this point in the history

  2. io_win32: support non-ASCII paths 

    Fixes protocolbuffers#3951
    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    65da9fd View commit details
    Browse the repository at this point in the history

  3. io_win32: add more encoding-related tests

    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    57a01c7 View commit details
    Browse the repository at this point in the history

  4. io_win32_unittest: use CWD as last tempdir 

    If the test cannot find a temp directory by
checking environment variables, it will fall back
to using the current working directory as the temp
directory root.

This is what the test used to do as of commit
protocolbuffers@6de51ca
and what was then changed by commit
protocolbuffers@792d098
    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    3f1b1a6 View commit details
    Browse the repository at this point in the history

  5. io_win32_unittest: fix condition in GetCwdAsUtf8

    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    eb3bd6e View commit details
    Browse the repository at this point in the history

  6. io_win32_unittest: remove incorrect error check 

    Unlike GetEnvironmentVariableW,
GetCurrentDirectoryW doesn't set
ERROR_INSUFFICIENT_BUFFER.
    @laszlocsomor
    laszlocsomor committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    a3a1c93 View commit details
    Browse the repository at this point in the history