fix: TypeError: Cannot read property 'errorCount' of undefined #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, there are situations when the .solhintignore file causes all inputs files being ignored. This is a problem because the 'reports' variable ends up being an empty array, and therefore reports[0] is undefined. This patch solves the problem by checking that reports array exists and has a length greater than 0. Thanks to Adam Spiers (@aspiers) who originally discovered a bug. Issue-URL: https://bytemeta.vip/repo/protofire/solhint/issues/239
|
@aspiers can we get this merged? we ran into this issue today and its stopping us from using |
|
I would love that but I don't maintain this repository. |
dbale-altoros
previously approved these changes
Jan 25, 2023
dbale-altoros
approved these changes
Jan 25, 2023
aspiers
referenced
this pull request
in toruichikawa/solhint
Aug 20, 2024
Without this patch, there are situations when the .solhintignore file causes all inputs files being ignored. This is a problem because the 'reports' variable ends up being an empty array, and therefore reports[0] is undefined. This patch solves the problem by checking that reports array exists and has a length greater than 0. Thanks to Adam Spiers (@aspiers) who originally discovered a bug. Issue-URL: https://bytemeta.vip/repo/protofire/solhint/issues/239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, there are situations when the .solhintignore file
causes all inputs files to be ignored. This is a problem because the
'reports' variable ends up being an empty array, and therefore
reports[0] is undefined.
This patch solves the problem by checking that the reports array exists
and has a length greater than 0.
Thanks to Adam Spiers (@aspiers) who originally discovered a bug.
Issue-URL: #239