Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError: Cannot read property 'errorCount' of undefined #351

Merged
merged 2 commits into from
Jan 25, 2023
Merged

fix: TypeError: Cannot read property 'errorCount' of undefined #351

merged 2 commits into from
Jan 25, 2023

Commits on Aug 8, 2022

  1. fix: TypeError: Cannot read property 'errorCount' of undefined 

    Without this patch, there are situations when the .solhintignore file
causes all inputs files being ignored. This is a problem because the
'reports' variable ends up being an empty array, and therefore
reports[0] is undefined.

This patch solves the problem by checking that reports array exists and
has a length greater than 0.

Thanks to Adam Spiers (@aspiers) who originally discovered a bug.

Issue-URL: https://bytemeta.vip/repo/protofire/solhint/issues/239
    @pycckuu
    pycckuu committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    61be87c View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Merge branch 'master' into fix-reports-0-undefined

    @dbale-altoros
    dbale-altoros authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9b6039e View commit details
    Browse the repository at this point in the history