Bump Cosmos to v0.46.7-pio-1 (from v0.46.6-pio-1) and create "pear" upgrade #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… due to the local cosmos import).
…re how to automatically exclude the nft object definitions though.
…er context rather than getting the context from the command to get viper from it multiple times.
…appOpt later. A lot of our nodes just use the default, which viper doesn't know about.
…special call to create the snapshots dir since it's no longer needed.
…LeaveGroup msg fee if it exists.
SpicyLemon
commented
Dec 14, 2022
…ated, and more importantly, the tests on it don't mess up other tests.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
+ Coverage 58.46% 58.51% +0.05%
==========================================
Files 206 206
Lines 25264 25256 -8
==========================================
+ Hits 14771 14779 +8
+ Misses 9398 9380 -18
- Partials 1095 1097 +2
|
|
@SpicyLemon nit: noticed a typo in the title. It should be (from v0.46.6-pio-1) |
19 tasks
iramiller
reviewed
Dec 19, 2022
| customMsgFeeFloor := server.GetServerContextFromCmd(cmd).Viper.GetInt64(CustomMsgFeeFloorPriceFlag) | ||
| app.SetConfig(testnet, true) | ||
| vpr := server.GetServerContextFromCmd(cmd).Viper | ||
| testnet := vpr.GetBool(EnvTypeFlag) |
There was a problem hiding this comment.
In this context the EnvTypeFlag overlaps heavily with ENV as a source of vars
nullpointer0x00
approved these changes
Dec 19, 2022
arnabmitra
approved these changes
Dec 19, 2022
SpicyLemon
commented
Dec 21, 2022
Comment on lines
+187
to
+199
| func RemoveLeaveGroupMsgFee(ctx sdk.Context, app *App) error { | ||
| typeURL := sdk.MsgTypeURL(&group.MsgLeaveGroup{}) | ||
| app.Logger().Info("deleting MsgLeaveGroup msg fee if it exists") | ||
| err := app.MsgFeesKeeper.RemoveMsgFee(ctx, typeURL) | ||
| if err == nil { | ||
| return nil | ||
| } | ||
| if errors.Is(err, msgfeestypes.ErrMsgFeeDoesNotExist) { | ||
| return nil | ||
| } | ||
| app.Logger().Error("error deleting MsgLeaveGroup msg fee", "error", err) | ||
| return err | ||
| } |
There was a problem hiding this comment.
This might not be needed anymore. Waiting a bit to find out.
There was a problem hiding this comment.
What's your take on this now @SpicyLemon ?
| @@ -14,3 +16,19 @@ message StoreKVPair { | |||
| bytes key = 3; | |||
| bytes value = 4; | |||
| } | |||
|
|
|||
| // BlockMetadata contains all the abci event data of a block | |||
| // the file streamer dump them into files together with the state changes. | |||
There was a problem hiding this comment.
I know this is coming from cosmos but this comment can be improved.
llama-del-rey
approved these changes
Jan 5, 2023
|
I'm going to close this.
Note that |
SpicyLemon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v0.46.7-pio-1(fromv0.46.6-pio-1)pearupgrade that runs migrations and deletes a msg fee that might be on theMsgLeaveGroupmessage.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes