Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ibc-go to v6.1 #1278

Merged
merged 9 commits into from
Jan 6, 2023
Merged

Update ibc-go to v6.1 #1278

merged 9 commits into from
Jan 6, 2023

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Dec 23, 2022

Description

Updates ibc-go/v5 to ibc-go/v6. This should only be merged in after #1265 has been merged in as we use cosmos 46.7. This is still using our custom provenance/ibc-go branch, but hopefully in the future we can remove it. In order to use ibc-go/v6 we had to update our custom provenance/ibc-go branch and provenance/wasmd.

closes: #1273


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo requested a review from a team as a code owner December 23, 2022 17:24
@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Merging #1278 (eef9322) into main (16f6d72) will increase coverage by 0.02%.
The diff coverage is 36.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1278      +/-   ##
==========================================
+ Coverage   58.62%   58.64%   +0.02%     
==========================================
  Files         206      206              
  Lines       25478    25486       +8     
==========================================
+ Hits        14937    14947      +10     
+ Misses       9434     9429       -5     
- Partials     1107     1110       +3     
Impacted Files Coverage Δ
app/upgrades.go 9.61% <ø> (ø)
x/marker/keeper/keeper.go 85.00% <ø> (ø)
x/marker/keeper/marker.go 51.39% <0.00%> (-0.08%) ⬇️
x/marker/keeper/msg_server.go 18.81% <0.00%> (ø)
x/marker/client/cli/tx.go 61.72% <33.33%> (+0.67%) ⬆️
app/app.go 87.01% <100.00%> (ø)
x/marker/types/msg.go 24.72% <100.00%> (+0.20%) ⬆️

Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but is missing changelog entry.

nullpointer0x00
nullpointer0x00 previously approved these changes Jan 4, 2023
Copy link
Contributor

@nullpointer0x00 nullpointer0x00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

llama-del-rey
llama-del-rey previously approved these changes Jan 5, 2023
@Taztingo Taztingo dismissed stale reviews from llama-del-rey and nullpointer0x00 via eef9322 January 5, 2023 20:08
@llama-del-rey
Copy link
Contributor

@Taztingo a question on this please.. Is there a reason for keeping SendTransfer : https://github.com/provenance-io/provenance/blob/main/x/marker/keeper/marker.go#L737 vs using MsgTransfer: cosmos/ibc-go#2446

@Taztingo
Copy link
Contributor Author

Taztingo commented Jan 6, 2023

@Taztingo a question on this please.. Is there a reason for keeping SendTransfer : https://github.com/provenance-io/provenance/blob/main/x/marker/keeper/marker.go#L737 vs using MsgTransfer: cosmos/ibc-go#2446

Initially, that's what I tried. However, there is validation done that prevents us from sending the marker. We need to bypass one of those checks so I had to call SendTransfer directly.

@Taztingo Taztingo enabled auto-merge (squash) January 6, 2023 13:59
@Taztingo Taztingo merged commit 77dace1 into main Jan 6, 2023
@Taztingo Taztingo deleted the taztingo/1273-ibc-go-v6 branch January 6, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ibc-go from v5 to v6.
3 participants