Bugfix: Convert async fs operation to sync so it doesnt fail in newer…

[renarsvilnis]

Bugfix: Convert async fs operation to sync so it doesn't fail in newer node.js versions as the now require a callback, can't be optional anymore.

Don't merge yet, tests are failing. Working on a fix.

Update:
Test failing, because unlinkSync actually expects a real file otherfails fails.

@pstadler, how should I fix it?

1. Allow it fail silently
2. Create a real temp file for tests
3. ???

[coveralls]

Coverage remained the same at 99.219% when pulling 8a1b09a on renarsvilnis:master into 7a40a11 on pstadler:master.

[renarsvilnis]

@pstadler So what should I do to fix it?

[pstadler]

You need to change this to unlinkSync:

flightplan/test/test.transport.shell.js

Line 36 in 5b9de0f

unlink: function() {}

[renarsvilnis]

Lol somehow missed it. Fixed.

[pstadler]

thanks 🍻

[pstadler]

Published on npm. Release notes: https://github.com/pstadler/flightplan/releases/tag/0.6.19