Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Convert async fs operation to sync so it doesnt fail in newer… #175

Merged
merged 2 commits into from
Aug 18, 2018
Merged

Bugfix: Convert async fs operation to sync so it doesnt fail in newer… #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
722eb79
Bugfix: Convert async fs operation to sync so it doesnt fail in newer…
renarsvilnis Aug 13, 2018
8a1b09a
Fix unlinkSync in tests
renarsvilnis Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/transport/shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ Shell.prototype.transfer = function(files, remoteDir, options) {

Future.wait(tasks);

fs.unlink(tmpFile);
fs.unlinkSync(tmpFile);

return results;
};
Expand Down
2 changes: 1 addition & 1 deletion test/test.transport.shell.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe('transport/shell', function() {
writeTempFile: WRITE_TEMP_FILE_STUB
},
'fs': {
unlink: function() {}
unlinkSync: function() {}
}
};

Expand Down