Fixes firestore replication of multiple document with the same server…

…Timestamp (#6436)
pubkey · Sep 24, 2024 · 5c6ec01 · 5c6ec01
1 parent 97f1c16
commit 5c6ec01
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 2 deletions.
diff --git a/src/plugins/replication-firestore/index.ts b/src/plugins/replication-firestore/index.ts
@@ -138,8 +138,8 @@ export function replicateFirestore<RxDocType>(
                     );
                     sameTimeQuery = query(pullQuery,
                         where(serverTimestampField, '==', lastServerTimestamp),
-                        where(primaryPath, '>', lastPulledCheckpoint.id),
-                        orderBy(primaryPath, 'asc'),
+                        where(documentId(), '>', lastPulledCheckpoint.id),
+                        orderBy(documentId(), 'asc'),
                         limit(batchSize)
                     );
                 } else {

diff --git a/test/replication-firestore.test.ts b/test/replication-firestore.test.ts
@@ -420,5 +420,40 @@ describe('replication-firestore.test.ts', function () {
 
             collection.database.destroy();
         });
+        it('replicates all docs with identical serverTimestamp from the server', async () => {
+            const firestoreState = getFirestoreState();
+            const collection = await humansCollection.create(0);
+
+            const now = new Date();
+            const h1 = {
+                ...makeFirestoreHumanDocument(
+                    schemaObjects.humanData('replicated-1', 35, 'replicated')
+                ),
+                serverTimestamp: now,
+            };
+            const h2 = {
+                ...makeFirestoreHumanDocument(
+                    schemaObjects.humanData('replicated-2', 27, 'replicated')
+                ),
+                serverTimestamp: now,
+            };
+
+            await setDoc(DocRef(firestoreState.collection, 'replicated-1'), h1);
+            await setDoc(DocRef(firestoreState.collection, 'replicated-2'), h2);
+
+            await syncOnce(collection, firestoreState, {
+                pull: {
+                    batchSize: 1,
+                },
+                push: {},
+            });
+
+            const allLocalDocs = await collection.find().exec();
+
+            assert.strictEqual(allLocalDocs.length, 2);
+
+            collection.database.destroy();
+        });
+
     });
 });