Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes firestore replication of multiple document with the same serverTimestamp #6436

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

djoume
Copy link
Contributor

@djoume djoume commented Sep 23, 2024

This PR contains:

  • A BUGFIX

Describe the problem you have without this PR

I noticed some documents where missing when replicating from firestore. I traced down the issue to a bug in the sameTimeQuery in the firestore plugin where we're querying for a document field instead of querying for a document id.

I'm not sure how to test a change to this library on my project, could you advise on how to do so? I don't think I can use npm link because of the build steps required.

@pubkey
Copy link
Owner

pubkey commented Sep 24, 2024

To test this, clone the rxdb project into your node_modules/rxdb. Then run npm run build inside of it.

@djoume
Copy link
Contributor Author

djoume commented Sep 24, 2024

I finally found what was preventing me for testing changes to rxdb, I had forgot to exclude rxdb from vite's optimizeDeps config.

I have been able to confirm that with this change all documents are being fetched, let me know if there is anything else I can do to help get this bugfix merged.

@pubkey pubkey merged commit 5c6ec01 into pubkey:master Sep 24, 2024
21 checks passed
@pubkey
Copy link
Owner

pubkey commented Sep 24, 2024

Thank you, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants