Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newline to show FB and Twitter buttons on same line #4821 #4867

Commits on Feb 20, 2019

  1. Remove newline to show FB and Twitter buttons on same line publiclab#…

    …4821
    
    Removing <br> tag was not simply enough, since facebook button root node is a div with display block.
    I am not that happy with this solution, because it relies on how Facebook renders its button, which can change at any time.
    Other solution I came up with was adding float:left and margin-right to twitter button, then it does not matter that Facebook button is block element, but still it relies on how twitter's script renders its button in iframe.
    Last solution I came up, but could not make work was wrapping both of them in divs and then position them based on our containers div with no regard what is inside.
    matvs committed Feb 20, 2019
    Configuration menu
    Copy the full SHA
    b3cd5cd View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Configuration menu
    Copy the full SHA
    75f4055 View commit details
    Browse the repository at this point in the history
  2. Update app/views/sidebar/_dashboard.html.erb

    Typo, closing tag.
    
    Co-Authored-By: swiatek7 <swiatek7@gmail.com>
    grvsachdeva and matvs authored Feb 21, 2019
    Configuration menu
    Copy the full SHA
    3be84eb View commit details
    Browse the repository at this point in the history