Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom shows wrong location/region #132

Closed
chuong opened this issue Aug 6, 2021 · 15 comments
Closed

Zoom shows wrong location/region #132

chuong opened this issue Aug 6, 2021 · 15 comments

Comments

@chuong
Copy link

chuong commented Aug 6, 2021

Firstly many thanks for the many enhancements included in this implementation.

Zoom is one of the nice features but when I tested the latest code, it displays a zoomed-in region very far from the pointer. The expected zoomed-in region should be around the mouse position or using the mouse position as the top left corner of the zoomed regions.

@rexelbartolome
Copy link

rexelbartolome commented Aug 6, 2021

Not entirely sure if the preview being far away from the pointer was actually intentional but regardless, I'd also like to add that because of this: trying to zoom to the edges of the screen will cause flickering on the viewfinder.

TSww3eT004.mp4

Also the pointer is smaller and misplaced compared to what I had on screen for some reason. I used ShareX with FFmpeg to record this vid. I'm a teacher and I hope to use the zoom feature that's available here instead of the Magnifier in Windows and the flickering might cause some problems with some photosensitive students.

I'm using a dual monitor setup if that's relevant. And also I'm really glad I found this app, I was having trouble with DemoHelper and Zoomit, so thanks for that.

@pubpub-zz
Copy link
Owner

a) on the edges, the area to be copied overlapped out of "screen" and the capture is capturing bad area. I knew this symptom but no one complained about yet. I will see if I can fix that quickly
b) ffmpeg does not capture screen cursor size and keep it at 32x32 : the bug is on its size😉 You can replace the cur files with a 32x32 and it will fix the global behavior
c) I also would recommand you to have a look at #92 discussion : you should set the properties to ensure not trouble with mutltiple screen.

@pubpub-zz
Copy link
Owner

Can you try this version for the zoom on the borders:
ppInk64_Zoom07a.zip

About your issue with the cursor, have you tried OBS ?

@rexelbartolome
Copy link

Can you try this version for the zoom on the borders:
ppInk64_Zoom07a.zip

About your issue with the cursor, have you tried OBS ?

Yes I usually use OBS anyway so it's no problem, I just use ShareX and ffmpeg for short video screenshots and things like that.

I've tried out the new file, and the flickering isn't present anymore, it just shows black instead, so definitely workable now in my case :D And the offset of the viewfinder to the cursor is still present, which I'm still not sure if it's intentional or not. So thanks for that 😊

@pubpub-zz
Copy link
Owner

Sorry I think I sent you to the wrong thread
Try this :
#97 (comment)

@rexelbartolome
Copy link

Sorry I think I sent you to the wrong thread
Try this :
#97 (comment)

Yea okay, I've changed it. I don't really see a difference 😅 but I'll keep it on so I don't encounter any bugs regarding DPI and all that... Thanks 😊

@pubpub-zz
Copy link
Owner

@rexelbartolome,
Just to confirm : the problem of offset is only visible through ffmpeg and you get no offset when looking directly at the screen ?

@pubpub-zz
Copy link
Owner

@chuong,
Have you tried
#97 (comment)

@rexelbartolome
Copy link

@rexelbartolome,
Just to confirm : the problem of offset is only visible through ffmpeg and you get no offset when looking directly at the screen ?

Hmmmm no, either way the zoom viewfinder still has an offset from the cursor. I double-checked and I might be mistaken on my previous post as only the size of the cursor changed with using ffmpeg and I must've thought that the placement of it also changed, turns out it might be the same offset. I used OBS now for this clip and used the new version that you provided, it still has an offset but the cursor size is correct since I'm not using ffmpeg anymore :)

2021-08-09.06-43-41.mp4

@pubpub-zz
Copy link
Owner

I have some troubles to see the offset you are talking about;
When I search the center position of the zoom it matches the head of the arrow:
image

I checked quickly everywhere and it looks good. If you don't think so, can you provide the snaptshot.

@rexelbartolome
Copy link

Oh okay I understand now, the offset I was talking about was the distance between the point of the cursor and the blue box, which is highlighted in yellow
ppInk_huUA7m74ZK

I guess it's more noticeable when the cursor is on the lower right and the viewfinder is on the upper left.
ppInk_e5KX22tApV

I see it as an offset because I used to use Windows' native magnifier in lens mode and the cursor is on the center of the viewfinder. I just expected the cursor to be at least inside the viewfinder, not outside of it
ppInk_gujjQsuUYq

2Bd2KFjwsI.mp4

But I guess that answers my question whether or not the offset was intentional or not, so maybe I just need to get used to it 😅 This way might be a better way of handling it too, since the viewfinder almost never gets clipped unlike Windows' version where if we zoom in on the corners, it gets clipped and goes outside the screen :)

@pubpub-zz
Copy link
Owner

My zoom is 100% dynamic, because of that, the enlarged area can not be displayed behind the cursor (zoomIt takes a snapshot only once and can not show changes behind.
On the pictures you have provided you can seen the zoom area is always centered on the cursor ( this is why now pixels within the rectangle centered on the cursor but out of the screens are now blackened) : the "yellow line" you've plot will never change even on borders. 😊

@pubpub-zz
Copy link
Owner

@chuong @rexelbartolome
I propose to close this thread

@rexelbartolome
Copy link

@chuong @rexelbartolome
I propose to close this thread

I'm okay with it 😄

@pubpub-zz
Copy link
Owner

pubpub-zz commented Aug 27, 2021

@chuong

@chuong @rexelbartolome
I propose to close this thread
Ok for you ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants