-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Selection #97
Comments
I've found a solution to implement multi Selection (first alpha version partially coded): In order to use it : there is a new icon (i've reduced moving Icon to not take to much place) You can click on undo to cancel the last selection modification. Can you give your feed back on usability |
I've tested this new feature and it works as intended. I would suggest being able to select these one at a time but I see you have that on the roadmap already. Your suggestion of hitting the eraser to move selected strokes seems pretty good to me! I'd personally like if you could see the combined length of the strokes you have selected, but it seems very much usable from what I've seen! |
Hello @pubpub-zz I'm testing your beta version in different cases, I'll post my observations about the multiple selector, pen width, load/save shortcuts and snapshot in a few hours. |
Hello @pubpub-zz, regarding the lasso function. I like how it works.
I'd be pretty nice!I I'll wait for it and also I'll wait for a hotkey to test it much better in order to get more details on usability. It's really intuitive to add an element/stroke to selection with left click, and use right click to remove, and the idea of erasing selected strokes by selecting eraser is nice too. I was testing the lasso by combining it with the move/copy functions and it works as expected. As I told you above I'll wait for a hotkey option to do more tests and get more results. For now, it works as expected! Thanks! |
Pens buttons selects Color/Transparency/Width/Linestyle /fading/... without changing tools which are independents, else how can you change color without changing tool. Consider thoses as Pen button and not Pen tool. Color picker is designed to modify the current pen definition not the standard way to select color It is a quicker way proposed to accelerate color selection which is normally done by the color picker in the pen dialogbox.
Yes... Not sure the problem is not part of Ink Library... |
Part of the coding in progress 😊 |
New alpha version with hotkeys and measurement |
This is already perfect IMO. The only thing I noticed was that lasso selection doesn't add the length, only click select. Great work :) |
have you seen 2nd line "Total" when hovering? |
Hmmm. I tested again and now it seems to be working. Upon first trying it, the second line wouldn't appear when strokes were selected using lasso. If I can reproduce I'll let you know. For now it seems to be working as intended, then. Lasso can get a bit laggy when you're drawing it though. Have you noticed this? If it's just me I can make a quick video. |
yes pls |
I think lag should be visible in this clip |
I was testing the usability of the lasso with hotkeys and combinations in many cases (around 30+) and It's incredible. I have no words to express this amazing feature. My congrats for it. I have some observations related to the lasso and others (not related to the lasso) My intention when I make these test videos is for you to improve some bugs or defects that I find (possible bugs, I don't know, If possible of course). I'm doing this analysis because, to be honest your software is the best of all programs (including online educational whiteboards) I've found and used on the internet so far. Honestly using ppInk, a class is far more dynamic than using online whiteboards, pdf annotators and other annotation tools. In addition I'm using ppInk for other purposes too, it's really intuitive, useful, very complete, easy to use for me. Well that's my point of view. Thanks for your attention. PS: I have an observation about the clipArt too but I will comment it later. |
As @NOVAinc already told you. Today, another issue I've noticed is about lagging when using the lasso with a regular amount of strokes by selecting and combining move/copy options. I confirm that it happens to me too. Even so the lasso works excellent. |
I'm so surprised : I do not have this effect aspecially with so little strokes. However I've had already work on some refactoring and some fixes (selection by click left/right to remove and undo) that should improve. Can you try this version. If you have the problem can you check with pen |
Odd. I have to try to reproduce... |
Hello @pubpub-zz, Occasionally I found this possible....bug? |
The new version works flawlessly for me! @pubpub-zz |
New beta fixing Text Move in groups and also should also fix the issue with pend dialog box opening on clipart reported @chrisj0192 |
@pubpub-zz I've been testing ppInk64_MultiSel09b these last days and I got these results:
Here you are two short videos about it. odd. |
@chrisj0192, |
@chrisj0192, any update? |
Hello @pubpub-zz long time no see, later I'll upload a bunch of massive results I've been doing these last few days. Sorry for not answering you, but my current job makes me feel exhausted. 😫 |
Yes, I wanted to be able to make hotkeys with escape, del or backspace. to delete hotkey now it is ctrl+shift+del or ctrl+shift+backspace |
Hello @pubpub-zz
I see, ok, thanks. This is my report. Test 1: Test 2: Test 3: Test 4 and test 5: lasso.test.6.mp4Test 6: In summary:
|
fixes *(Save confirmation continuous) #106 (comment) *(Pens hotkeys modifiers ignored) #97 (comment)
Hey thanks for this, I has just started using this and this feels already so great. I do have some suggests and comments. Clipart -
Zoom Tool -
Edit Tool -
Bug in Docking/Undocking Toolbar-
I will let you know if I find anything more. Overall this is so cool, its way more than what I thought would be possible. |
Reproduced. I will try to fix it very next release
Quite in line with my proposal #97 (comment)
can you provide video ?
when zooming, you capture in zoom2, you snapshot the area, expand it and allow drawing over, but your drawing can't be restored like that for the moment...
this is an idea, not for next release. Can you open a new issue for tracking
this is because "engage Pointer and auto-fold with Alt+Tab" is set in options.
this is because "engage Pointer and auto-fold with Alt+Tab" is set in options. Globally expected for same reason
Happy you enjoy 😊 |
Hey, Debugging background -
Here is a video of the zoom bug that I was able to reproduce: bug.in.zooming.mp4There seems to be something wrong with the zoom 1 mode as well, I don't remember that the previous time I checked it out, but now it seems to persist even after exiting and restarting many times, probably I might have missed it the first time. I have shown the options before and after (both are same) just to be complete. Here is a recording of the docking undocking bug that I had mentioned about : bug.in.docking.undocking.mp4Notice that the every first time after I toggled to Mouse pointer, my very first mouse click was answered by by toggling back into ppink overlay, although this is pretty infrequent. I saw this the during my first time as well, but was unable to reproduce it so didnt report it. And the second part which is undocking the toolbar when its supposed to toggle to mouse pointer mode. I have shown the options before and after (both are same) just to be complete. Do you want me to try this with Engage point and auto-fold enabled? I didn't understand this feature so had it turned of the first time. Hope this is helpful. Let me know if I should do anything more.
Sure I'll do that now. |
Hello @pubpub-zz
I'd done those actions before hehe and yes I like the idea, but that's why I was wondering if it's possible to add a math editor. Actually, it's not necessary because I use handfree drawing to make strokes related to math operators (it's more comfortable for me, although it would be more comfortable if I had a graphics tablet soon hehe) but I agree with you to add an option to add the clipboard to the clipart, select it and be read to draw it when returning from pointer mode (I like this idea). Another thing that I found very necessary is a sort option, because I have more than 100 images in my clipArt hehe. It would be nice to have an option to sort them by name (in my case). I use codes to identify the names of my images. On the other hand, I found a problem related to fading and eraser. When I use fading and immediately swap to the eraser to delete some strokes (using alt), this dialog window shows up. As xxBloodyMaryxx told you, Another one is when I use pan function (move all strokes), Images loaded from the clipArt don't move (I forgot to report this one). Finally, a question, is it possible to have a custom color palette? similar to the ms paint palette (It would be great to quickly change from one color to another) because we only have 10 pens and I use other colors for the highlighters. Thanks in advance. |
Can you create a new issue for this please. may come in 1.8, not 1.7
There is two things: I tried it in
Problem reproduced and fixed(normally)
as promised, it is fixed
My recommandation would be to make a bat program using curl or a powershell script that would use the Rest API to modify the pens as required. Then you would just have to run it (even in pointer mode) to modify pens definitions. |
@xxBloodyMaryxx, about you zoom issue can you tell how many screens you are using and what is the scale you are using
apparently ppInk does not received focus. when required. I've added extra code, can you tell me if it is better |
ppInk64_varFixes09b.zip review - Settings Changes:
Pan Bug in Clipart - clipart.bug.mp4I am using 1080p default laptop screen. I haven't configured any other display in this machine. I have reproduced it with ppInk64_varFixes09b.zip: zoom.bug.mp4Yes, I think after toggling to Mouse pointer (which apparently only after first getting the toolbar undocked), it seems to require a click to move the focus out. Following is what I could capture - docking.bug.mp4The Pointer and Autofold was disabled for this last recording. Something unrelated: |
about the issue with the zoom, I reminds me of #92, colorpicker issue. in a word the issue fix should be change the compatibility / advanced PPP compatibility in ppInk.exe properties (sorry for french) About the click, after pointer mode, can you check that another program (maybe your key dispay) is not interfering Finaly about pan and typo, tripple oups!!!!!!!!! should be good now |
Reviewing ppInk64_edit10b.zip - Amazing, the advanced compatibility option did fix the issue with both zoom modes. Pan is also working great now. The only bug that's left is the docking/undocking one I think. I noticed a pattern: docking.bug.mp4During every first attempt after starting ppink.exe afresh, the global hotkey toggles the mouse pointer WITHOUT undocking the toolbar, the next mouse click does bring back focus to other windows (verified by spacebars that scroll the webpage) but at the same time activates the ppink again (two actions simultaneously). This happens only for first attempts. For furthur attempts, the global hotkey first undocks the toolbar, and subsequently toggles the mouse pointer while the toolbar is undocked. There is a click going unanswered where the focus is getting shifted to the ppink overlay from ppink toolbar. I am positive that there are no applications (atleast those I am aware of) that are interfering including the key logging since the was able to reproduce the same when the keylogging wasn't running. Also, I tried doing this with the toolbar disabled (within the config,ini) and everything was as expected, no issues there. |
Hello @pubpub-zz
Ok, I'll create it.
Thanks for your recommendation, I've already tried it 😊
I confirm the eraser vs fading issue is fixed now. it works perfectly swapping them.
About pan function, I saw this issue was reported and now you've fixed it, In ppInk64_pan10a.zip, I confirm pan function works perfectly!
I'm going to try your recommendation. Thank you 😊 Finally I detected a little bit problem with the color picker, it's the first time I use it and with the alt key the color picker gets stuck and without the alt key it also gets stuck. I need to press twice to get back to the canvas cursor. I'm not sure if it's a normal function, could you try it? Thank you for your amazing work! |
|
Unload as in? I am using this: https://github.com/xxdocobxx/DisplayKeystroke Its a portable executable file that goes off grid as soon as I close (atleast it goes off task manager). Is this the one causing the issue? |
I meant quit the program |
I've prepared a test program to show active window. |
Oh okay interesting. This is what I have got with ppInk64_invst11a.zip docking.issue.mp4@pubpub-zz Is it an issue with my Global Hotkey maybe? |
Hi @YouFoundJK, |
Can you test this version : I did some change on the pointermode. The first test case raised by @YouFoundJK is when you enter/exit pointer mode with the toolbardock. The issues was some requirement to click many times to get pen active. Note that is normal that the toolbar stays folded if it was folded before entering pointer mode. |
I have tested it and it seems pretty good! Performance is great and the issues I noticed I haven't run into with this one so I think they might be gone. I'll make a switch to this version for work so I'll get more testing done! |
Looking forward to see some video with animated gif |
Waiting for a few feed back and one translation and I will issue 1.7RC2 |
Insane, the docking thing is fixed, and I couldn't find any more issue. This seems to be pretty stable. @pubpub-zz How come only I had that changing focus issue? Is it some Windows setting that I might have messed up with? |
@YouFoundJK, |
Hello @pubpub-zz I hope you are well, it seems you didn't read my last comment, I'd like to know your answer.
In addition I'd like to know, what's your opinion about a curved line?, is it feasible to integrate it in ppInk? Thanks. |
@chrisj0192 If yes, can you make a video pls |
I agree this could be interesting, but this may be quite complex for both implementation and Operator interaction(I want to keep the interface compatible with a full tablet(touch only) mode) Will think about it. 👍
Originally posted by @pubpub-zz in #95 (comment)
Originally posted by @pubpub-zz in #92 (comment)
The text was updated successfully, but these errors were encountered: