Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dugite to 2.5.2 #39

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Bump dugite to 2.5.2 #39

merged 2 commits into from
Dec 13, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 13, 2023

Description of the Change

  • Bump dugite to 2.5.2
  • Bump whats-my-line to a dedicated branch where the only new change is bumping dugite to 2.5.2
    • (avoiding the superstring bump on whats-my-line master, as I'm not set up to sync the superstring bump across all three packages that depend on it at once just yet)

Screenshot or Gif

N/A

Applicable Issues

See also: pulsar-edit/whats-my-line#8
Follows up on: #36

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does in fact just do the bump as expected.

Although without tests hard to tell exactly where we are. But fingers crossed we are good to go

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 13, 2023

Looking at the CI, the baseline state of things isn't super great but I don't see anything that looks truly like a new issue as of this PR.

  • Number of failing tests is identical on the Ubuntu-20.04 runs of both latest master commit and for this PR (18).
  • Number of fails is up 19 --> 22 for the ubuntu-latest test runs, but I didn't see any categorically new-looking ones. I can see that it's specifically a different number of failures (looks like CI flakiness/run-to-run variance?) in the sub-tests of some problematic test topics (integration: file patches and WorkerManager).
    • Reading the most into this, it could be a tiny perf regression leading to more timeouts in these tests, but perf is so variable on CI machines for GitHub Actions I would not read this much into it, personally.
    • Out of hundreds of assertions, only increasing by 3 within existing categories that have multiple flakes each run already seems like run-to-run noise that could be ruled out by running another CI run, I guess. I don't think it's worth it, though, I don't really have time to mess with it at the moment :/.
  • macOS and Windows test runs, on master branch even before this PR, (consequently also for this PR of course) are broken, failing to even install the dependencies (such as for Python 3.12 issues, etc.)
    • These are too badly maintained to even meaningfully look at at the moment :/ They need a fix when someone gets the chance.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 13, 2023

Basically working on my machine, didn't throw any errors on startup, was able to sync latest commits from the remote for my local clone of pulsar repo.

I'll merge this and ask @Daeraxa if this works on their ARM Linux machines before doing a PR to core?

(How to test: ppm install https://github.com/pulsar-edit/github after this merges, or clone this repo and ppm install + ppm link).

EDIT: Thanks for review!!

@DeeDeeG DeeDeeG merged commit 04f5430 into master Dec 13, 2023
0 of 5 checks passed
DeeDeeG added a commit that referenced this pull request Dec 16, 2023
Temporarily revert the `dugite` bump just before
syncing this package to core.

Today is Regular release day for core, and I would like to have
more testing of the dugite bump in Pulsar Rolling
before committing to it in Regular.

This reverts commit 04f5430, reversing
changes made to 06d9dbb.
DeeDeeG added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants