-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dugite to 2.5.2 #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does in fact just do the bump as expected.
Although without tests hard to tell exactly where we are. But fingers crossed we are good to go
Looking at the CI, the baseline state of things isn't super great but I don't see anything that looks truly like a new issue as of this PR.
|
Basically working on my machine, didn't throw any errors on startup, was able to sync latest commits from the remote for my local clone of pulsar repo. I'll merge this and ask @Daeraxa if this works on their ARM Linux machines before doing a PR to core? (How to test: EDIT: Thanks for review!! |
Description of the Change
master
, as I'm not set up to sync the superstring bump across all three packages that depend on it at once just yet)Screenshot or Gif
N/A
Applicable Issues
See also: pulsar-edit/whats-my-line#8
Follows up on: #36