-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update dugite to 2.5.2 #8
Conversation
There's no It's not really relevant to us, thankfully, since we're not building for 32-bit x86 Linux. For now, I can update to 2.5.1 instead in this PR, but I would keep this PR open for a few days to see if they get a chance to publish 2.5.2 to the npm registry. |
c308c1a
to
9391d71
Compare
Should add support for ARM Linux.
9391d71
to
0cc4a5a
Compare
Okay, dugite 2.5.2 was published to the npm package registry! Re-bumping here (I forgot to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see this! Thanks for keeping the bump pinned to reduce our concern in these deps becoming out of date. As long as this is followed up with a bump in github
then I fully support merging this one in, thanks for the effort!
I think I'm gonna make sure the Appreciate the review! One less plate to spin to make sure it all lines up. This part is "good" but parked until the other half is ready I guess? (Or if someone beats me to it, feel free to merge this + a bump at I do intend to get to it "soonish", not 100% sure if before/after Regular, but might catch up regarding timing here or on Discord soon to sort that out. |
Merging this with a PR to be posted at github repo more or less immediately after. (I need to merge this first, then get the SHA of the merge commit from merging this, so I can bump BRB merging and then second PR. (Thanks again for review!) |
Welp, I forgot this repo bumped See this branch: And now, the PR over at the github package's repo: pulsar-edit/github#39 |
This should add support for ARM Linux.
Once we bump
dugite
here and ingithub
package, I expect thegithub
package may start working in Pulsar on ARM Linux? See release notes fordugite
here: https://github.com/desktop/dugite/releases