Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update dugite to 2.5.2 #8

Merged
merged 1 commit into from
Dec 13, 2023
Merged

deps: Update dugite to 2.5.2 #8

merged 1 commit into from
Dec 13, 2023

Conversation

DeeDeeG
Copy link
Member

@DeeDeeG DeeDeeG commented Dec 2, 2023

This should add support for ARM Linux.

Once we bump dugite here and in github package, I expect the github package may start working in Pulsar on ARM Linux? See release notes for dugite here: https://github.com/desktop/dugite/releases

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 2, 2023

There's no dugite 2.5.2 on the npm package registry... I opened an issue asking them to publish it: desktop/dugite#554

It's not really relevant to us, thankfully, since we're not building for 32-bit x86 Linux. For now, I can update to 2.5.1 instead in this PR, but I would keep this PR open for a few days to see if they get a chance to publish 2.5.2 to the npm registry.

@DeeDeeG DeeDeeG marked this pull request as draft December 2, 2023 21:01
Should add support for ARM Linux.
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 7, 2023

Okay, dugite 2.5.2 was published to the npm package registry!

Re-bumping here (I forgot to update package-lock.json the first time, apparently.) And this should be good to go! I'll mark it as ready for review.

@DeeDeeG DeeDeeG marked this pull request as ready for review December 7, 2023 19:21
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see this! Thanks for keeping the bump pinned to reduce our concern in these deps becoming out of date. As long as this is followed up with a bump in github then I fully support merging this one in, thanks for the effort!

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 12, 2023

I think I'm gonna make sure the github side of things is ready to go at the same time to keep things synced up.

Appreciate the review! One less plate to spin to make sure it all lines up. This part is "good" but parked until the other half is ready I guess? (Or if someone beats me to it, feel free to merge this + a bump at github repo!)

I do intend to get to it "soonish", not 100% sure if before/after Regular, but might catch up regarding timing here or on Discord soon to sort that out.

@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 13, 2023

Merging this with a PR to be posted at github repo more or less immediately after.

(I need to merge this first, then get the SHA of the merge commit from merging this, so I can bump whats-my-line dependency under github package's package.json to that SHA.)

BRB merging and then second PR. (Thanks again for review!)

@DeeDeeG DeeDeeG merged commit 177afe5 into master Dec 13, 2023
6 checks passed
@DeeDeeG
Copy link
Member Author

DeeDeeG commented Dec 13, 2023

Welp, I forgot this repo bumped superstring already, so until I've set everything up to sync the superstring bump across all three packages that depend on it, I have to make "just the dugite bump" be its own branch again, like last time. (Or some similar solution, but I'll do that again.)

See this branch: just-the-dugite-2.5.2-bump

And now, the PR over at the github package's repo: pulsar-edit/github#39

DeeDeeG added a commit that referenced this pull request Jan 25, 2024
This reverts commit 177afe5, reversing
changes made to f4bcc71.

De-bump dugit from 2.5.2 to 2.1.0, temporarily.
Trying out just the superstring bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants