Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create upgrade issues for beta releases #749

Closed
iwahbe opened this issue Dec 15, 2023 · 2 comments · Fixed by pulumi/upgrade-provider#226
Closed

Don't create upgrade issues for beta releases #749

iwahbe opened this issue Dec 15, 2023 · 2 comments · Fixed by pulumi/upgrade-provider#226
Assignees
@VenelinMartinov
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@iwahbe
Copy link
Member

iwahbe commented Dec 15, 2023

Our new automation created the issue: pulumi/pulumi-postgresql#336.

We shouldn't see upgrade issues for beta releases.
@guineveresaenger
Copy link
Contributor

This is an issue in https://github.com/pulumi/upgrade-provider - tooling assumes that latest is a stable version. My suggestion would be to add a catch for non-major-minor-patch and skip creating the issue.

@VenelinMartinov VenelinMartinov mentioned this issue Dec 27, 2023
Merged
VenelinMartinov added a commit to pulumi/upgrade-provider that referenced this issue Dec 27, 2023
@VenelinMartinov @iwahbe
Ignore beta releases (#226)
b9893a3 
Fixes pulumi/ci-mgmt#749

When looking up the latest version of an upstream provider, we should
skip beta releases.
This PR achieves this by getting the list of the latest 30 releases and
then iterating over them until it finds a non-beta release when looking
up latest.

---------

Co-authored-by: Ian Wahbe <ian@wahbe.com>
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 27, 2023
@pulumi-bot pulumi-bot reopened this Dec 27, 2023
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@iwahbe iwahbe added the kind/bug Some behavior is incorrect or out of spec label Dec 27, 2023
@iwahbe iwahbe closed this as completed Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VenelinMartinov VenelinMartinov

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore beta releases pulumi/upgrade-provider
4 participants
@guineveresaenger @iwahbe @VenelinMartinov @pulumi-bot