Ignore beta releases #226
Merged
Ignore beta releases #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
approved these changes
Dec 27, 2023
| @@ -511,18 +511,25 @@ var getExpectedTargetLatest = stepv2.Func21E("From Upstream Releases", func(ctx | |||
| name, upstreamOrg string) (*UpstreamUpgradeTarget, error) { | |||
| latest := stepv2.Cmd(ctx, "gh", "release", "list", | |||
There was a problem hiding this comment.
We should use --json when possible. Tracking issue is cli/cli#4572.
| @@ -292,3 +290,50 @@ func TestGetExpectedTargetFromTarget(t *testing.T) { | |||
| "GHIssues": null | |||
| }`)) | |||
| } | |||
|
|
|||
| func TestFromUpstreamReleasesBetaIgnored(t *testing.T) { | |||
Co-authored-by: Ian Wahbe <ian@wahbe.com>
…provider into vvm/ignore_beta_releases
guineveresaenger
added a commit
that referenced
this pull request
Jan 2, 2024
…rgetLatest (#220) See #218 for details. Uses the full json repo info payload to determine the latest upstream release. See pulumi/pulumi-minio#251 for the fix applying to pulumi-minio specifically. Fixes #218. Fixes pulumi/pulumi-f5bigip#345 Fixes pulumi/pulumi-venafi#244 ~**Reviewer Note**: This functionality overrides the changes in #226. Note that we're returning an empty UpgradeTargetVersion in the case of a non-stable release, so that the nil check on `Plan Provider Upgrade` reports that we are up to date. A `latest` version with a beta tag should not fail the upgrade process; we should ignore it.~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pulumi/ci-mgmt#749
When looking up the latest version of an upstream provider, we should skip beta releases.
This PR achieves this by getting the list of the latest 30 releases and then iterating over them until it finds a non-beta release when looking up latest.