Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v5.17.0 #2812

Closed
pulumi-bot opened this issue Sep 14, 2023 · 3 comments · Fixed by #2817
Closed

Upgrade terraform-provider-aws to v5.17.0 #2812

pulumi-bot opened this issue Sep 14, 2023 · 3 comments · Fixed by #2817
Assignees
@t0yv0
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.94

Comments

@pulumi-bot
Copy link
Contributor

Release details: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.17.0
@pulumi-bot pulumi-bot added the kind/enhancement Improvements or new features label Sep 14, 2023
@t0yv0 t0yv0 self-assigned this Sep 18, 2023
@t0yv0
Copy link
Member

t0yv0 commented Sep 18, 2023

Automated upgrade failed.

U go.sum
make: *** [Makefile:119: upstream] Error 1

upgrade-provider: v0.0.0-20230912002116-9e1e9010a7e9

This may have been fixed in subsequent versions. I'm going to rerun.

@t0yv0
Copy link
Member

t0yv0 commented Sep 18, 2023

go: downloading github.com/pulumi/upgrade-provider v0.0.0-20230915232329-b8901aa1bf6b

Same error.

This was referenced Sep 18, 2023
Closed
Merged
t0yv0 added a commit that referenced this issue Sep 18, 2023
@t0yv0
Upgrade upstream to v5.17.0 (#2817)
8a12083 
Fixes #2812
Fixes #2806

We could not use upgrade-provider for this operation because there was a
conflict between upstream changes editing a go.sum and one of our
patches doing the same, so the patch did not apply cleanly. Resolved
manually by rebating upstream and rebuilding the patch set.

The new upstream version targeted here is 5.17.0.

On top of the upstream upgrade, this PR updates dependencies from
pulumi-terraform-bridge to propagate bugfixes:

- github.com/pulumi/pulumi-terraform-bridge/pf v0.16.1
- github.com/pulumi/pulumi-terraform-bridge/v3 v3.60.0
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Sep 18, 2023
@t0yv0 t0yv0 reopened this Sep 22, 2023
@t0yv0 t0yv0 mentioned this issue Sep 22, 2023
Merged
t0yv0 added a commit that referenced this issue Sep 27, 2023
@t0yv0
Upgrade terraform provider aws to v5.18.0 (#2827)
d7021d8 
Unfortunately
8a12083
did not really happen as the commit didn't include ./upstream and
patches changes due to human error.

I've reopened 5.17.0 upgrade ticket. The provider actually remains on
5.16.2 right now.

For the same reasons of go.sum conflict as in
#2817 upgrade-provider
continues unable to process these upgrades. I've started the process
manually here again for v5.16.2..v5.18.0.

Unfortunately we have a new problem here, upstream no longer compiles:

```
go build -v all                                                 
github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy
# github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy
internal/service/s3legacy/bucket_legacy.go:1425:35: meta.(*conns.AWSClient).S3ConnURICleaningDisabled undefined (type *conns.AWSClient has no field or method S3ConnURICleaningDisabled)
```

We will need another patch here to carefully test deletion on the S3
bucket legacy.

When complete it would be fixing:

- #2812
- #2822
@t0yv0
Copy link
Member

t0yv0 commented Sep 27, 2023

Fixed in #2827

@t0yv0 t0yv0 closed this as completed Sep 27, 2023
@t0yv0 t0yv0 added this to the 0.94 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.94
Development

Successfully merging a pull request may close this issue.

Upgrade upstream to v5.17.0 pulumi/pulumi-aws
2 participants
@t0yv0 @pulumi-bot