Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade terraform-provider-aws to v5.18.0 #2822

Closed
pulumi-bot opened this issue Sep 21, 2023 · 2 comments
Closed

Upgrade terraform-provider-aws to v5.18.0 #2822

pulumi-bot opened this issue Sep 21, 2023 · 2 comments
Assignees
@t0yv0
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.94

Comments

@pulumi-bot
Copy link
Contributor

Release details: https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.18.0
@pulumi-bot pulumi-bot added the kind/enhancement Improvements or new features label Sep 21, 2023
@t0yv0 t0yv0 mentioned this issue Sep 22, 2023
Merged
t0yv0 added a commit that referenced this issue Sep 27, 2023
@t0yv0
Upgrade terraform provider aws to v5.18.0 (#2827)
d7021d8 
Unfortunately
8a12083
did not really happen as the commit didn't include ./upstream and
patches changes due to human error.

I've reopened 5.17.0 upgrade ticket. The provider actually remains on
5.16.2 right now.

For the same reasons of go.sum conflict as in
#2817 upgrade-provider
continues unable to process these upgrades. I've started the process
manually here again for v5.16.2..v5.18.0.

Unfortunately we have a new problem here, upstream no longer compiles:

```
go build -v all                                                 
github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy
# github.com/hashicorp/terraform-provider-aws/internal/service/s3legacy
internal/service/s3legacy/bucket_legacy.go:1425:35: meta.(*conns.AWSClient).S3ConnURICleaningDisabled undefined (type *conns.AWSClient has no field or method S3ConnURICleaningDisabled)
```

We will need another patch here to carefully test deletion on the S3
bucket legacy.

When complete it would be fixing:

- #2812
- #2822
@t0yv0
Copy link
Member

t0yv0 commented Sep 27, 2023

Fixed in #2827

@t0yv0 t0yv0 self-assigned this Sep 27, 2023
@t0yv0 t0yv0 added this to the 0.94 milestone Sep 27, 2023
@t0yv0 t0yv0 closed this as completed Sep 27, 2023
@pulumi-bot pulumi-bot reopened this Sep 27, 2023
@pulumi-bot
Copy link
Contributor Author

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Sep 27, 2023
@t0yv0 t0yv0 closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t0yv0 t0yv0

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.94
Development

No branches or pull requests
2 participants
@t0yv0 @pulumi-bot