Do not depend on specific sdk #1425
Conversation
| @@ -269,9 +264,7 @@ func Provider() tfbridge.ProviderInfo { | |||
| }, | |||
| CSharp: &tfbridge.CSharpInfo{ | |||
| RespectSchemaVersion: true, | |||
| PackageReferences: map[string]string{ | |||
There was a problem hiding this comment.
Suspiciously python SDK didn't get changed, possibly still OK?
There was a problem hiding this comment.
I think it probably should have changed the pyproject.toml. The version ranges currently there match what was set in the schema
There was a problem hiding this comment.
Naively, I expected
to changeThere was a problem hiding this comment.
Per Justin this is polyfilled as a default in Python; once we upgrade codegen this will change. So OK for now.
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
| Requires: map[string]string{ | ||
| "pulumi": ">=3.0.0,<4.0.0", | ||
| }, |
There was a problem hiding this comment.
Nit: It shouldn't matter, but in some cases you're deleting the whole line like here, and in other cases you're leaving an empty map.
|
This PR has been shipped in release v5.53.5. |
Re: pulumi/ci-mgmt#1091