Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: module 'pulumi.runtime' has no attribute 'invoke_output' #1091

Closed
13 of 80 tasks
t0yv0 opened this issue Oct 1, 2024 · 8 comments
Closed
13 of 80 tasks
Assignees
Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 1, 2024

Remediate "AttributeError: module 'pulumi.runtime' has no attribute 'invoke_output'".

From @justinvp:

These are the relevant changes and releases:
pulumi/pulumi#17237 - Core SDK and sdkgen change for Node.js (released in v3.133.0)
pulumi/pulumi#17275 - Core SDK and sdkgen change for Python (released in v3.134.0)
pulumi/pulumi#17316 - Bump Node.js sdkgen’s min version to v3.133.0 (released in v3.134.0)
pulumi/pulumi#17353 - Fix bug in Node.js Core SDK (short-circuit output invokes if inputs contains unknowns) (released in v3.134.1)
pulumi/pulumi#17390 - Bump Node.js and Python sdkgen’s min version to v3.134.1 (released in v3.135.0)

Summary:
v3.133.0 sdkgen is problematic for Node.js. It needs v3.135.0 sdkgen and to not be setting the explicit @pulumi/pulumi dependency so that sdkgen emits the default min version.
v3.134.0 sdkgen is problematic for Python. It needs v3.135.0 sdkgen and to not be setting the explicit pulumi dependency so that sdkgen emits the default min version.

To remediate we need to make sure to remove explicit p/p dependency, for example:

Also please remove it for .NET

Native Providers

Bridged Providers

Tier 1

Tier 2

@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Oct 1, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

@pulumi/providers

I'll have a quick look at AWS ones, and tier 1.

@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

Per @danielrbradley there are some uncertainties whether the .NET change is wanted or not so we're scoping that out and leaving as-is for now.

t0yv0 added a commit to pulumi/pulumi-azuread that referenced this issue Oct 1, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 1, 2024

I'm at EOD status so far:

  • aws classic seems clean already
  • azuread releasing
  • aws-native, azure, gcp will auto-release when approved
  • k8s stood up but I'll need k8s squad to approve
  • need azure squad to help with azure-native follow up but the urgent handling is done afaik

Will work with @flostadler to cover AWS Tier-2+ things tomorrow.

For the long tail of bridged providers I think we can script this as they're pretty uniform.

Will need to load-balance and assign remaining native ones @mjeffryes

t0yv0 added a commit to pulumi/pulumi-kubernetes that referenced this issue Oct 1, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
    for Pulumi's contribution guidelines.

    Help us merge your changes more quickly by adding more details such
    as labels, milestones, and reviewers.-->

### Proposed changes

<!--Give us a brief description of what you've done and what it solves.
-->

Re: pulumi/ci-mgmt#1091

Since the original dependency required higher SDK versions than 3.x.x.,
the remediation also upgrades SDK generators to latest.

### Related issues (optional)

<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0 added a commit to pulumi/pulumi-aws-native that referenced this issue Oct 1, 2024
t0yv0 added a commit to pulumi/pulumi-gcp that referenced this issue Oct 1, 2024
t0yv0 added a commit to pulumi/pulumi-azure that referenced this issue Oct 1, 2024
@flostadler
Copy link
Contributor

Checking in here. I'm working my way through the AWS providers now

@VenelinMartinov
Copy link
Contributor

#1092 should address this for all the lower tier providers

github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2024
This adds a migration for providers to remove the explicit SDK
dependencies for python and javascript.

this should solve #1091 for tier
2+ providers

I've tested this on pulumi-cloudflare and pulumi-random. I've also
tested it doesn't do anything the second time around.
@VenelinMartinov VenelinMartinov removed the needs-triage Needs attention from the triage team label Oct 2, 2024
@flostadler
Copy link
Contributor

I created PRs for AWS Tier-2+ providers and added them to the list above. For EKS I've targeted it for EKS v3 because the current v2 is not affected (uses v3.129.0 for generating the schema).

flostadler added a commit to pulumi/pulumi-aws-apigateway that referenced this issue Oct 2, 2024
Re: pulumi/ci-mgmt#1091

This additionally bumps the pu/pu version to `3.135.0`.
flostadler added a commit to pulumi/pulumi-awsx that referenced this issue Oct 2, 2024
Re: pulumi/ci-mgmt#1091

This additionally bumps the pu/pu version to 3.135.0.
@t0yv0
Copy link
Member Author

t0yv0 commented Oct 2, 2024

Thanks all, very fast work here!

Stood up 3 more PRs for native providers, PTAL.

google-native won't fix I think.

Need review on those 3 PRs and still need help on azure-native, once that's in we can close I think.

@t0yv0 t0yv0 self-assigned this Oct 2, 2024
t0yv0 added a commit to pulumi/pulumi-command that referenced this issue Oct 2, 2024
t0yv0 added a commit to pulumi/pulumi-docker-build that referenced this issue Oct 2, 2024
flostadler added a commit to pulumi/pulumi-eks that referenced this issue Oct 2, 2024
Re: pulumi/ci-mgmt#1091

This additionally bumps the pu/pu version to 3.135.0.
t0yv0 added a commit to pulumi/pulumi-kubernetes-cert-manager that referenced this issue Oct 2, 2024
@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Oct 3, 2024
@t0yv0 t0yv0 closed this as completed Oct 3, 2024
@pulumi-bot pulumi-bot reopened this Oct 3, 2024
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: kind/

Please fix these problems and try again.

@t0yv0 t0yv0 added kind/task Work that's part of an ongoing epic and removed kind/task Work that's part of an ongoing epic labels Oct 3, 2024
@t0yv0 t0yv0 closed this as completed Oct 3, 2024
flostadler added a commit to pulumi/pulumi-eks that referenced this issue Oct 17, 2024
Re: pulumi/ci-mgmt#1091

This additionally bumps the pu/pu version to 3.135.0.
flostadler added a commit to pulumi/pulumi-eks that referenced this issue Oct 17, 2024
Re: pulumi/ci-mgmt#1091

This additionally bumps the pu/pu version to 3.135.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Work that's part of an ongoing epic resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants