-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Create/Update previews. #1355
Conversation
Implement support for the recently-added "provider preview" feature of the Pulumi plugin interface that allows a resource provider to return known values from a call to Create or Update during a preview. This feature improves the usability of previews by allowing more values to be treated as known. When previewing a Create or Update operation, the Kuberentes provider will either return the result of a dry-run performed by the API server or will return the inputs as-is. The dry-run is preferred, but is only possible when all of the inputs to the resource are known, the API server supports dry-running the resource in question, and the user has explicitly enabled the feature using the `enableDryRun` configuration property. Returning the inputs as-is matches the behavior previously implemented by the Pulumi engine.
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/304723801 |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/304812858 |
# Conflicts: # provider/go.mod # provider/go.sum
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/305258210 |
This change fixes a panic introduced in #1355. The panic occurred in cases where the provider attempted to set the last applied config annotation with computed values.
This change fixes a panic introduced in #1355. The panic occurred in cases where the provider attempted to set the last applied config annotation with computed values.
This change fixes a panic introduced in #1355. The panic occurred in cases where the provider attempted to set the last applied config annotation with computed values.
Implement support for the recently-added "provider preview" feature of
the Pulumi plugin interface that allows a resource provider to return
known values from a call to Create or Update during a preview. This
feature improves the usability of previews by allowing more values to be
treated as known.
When previewing a Create or Update operation, the Kuberentes provider
will either return the result of a dry-run performed by the API server
or will return the inputs as-is. The dry-run is preferred, but is only
possible when all of the inputs to the resource are known, the API
server supports dry-running the resource in question, and the user has
explicitly enabled the feature using the
enableDryRun
configurationproperty. Returning the inputs as-is matches the behavior previously
implemented by the Pulumi engine.
Proposed changes
Related issues (optional)