Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic with computed values on preview #1368

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Fix panic with computed values on preview #1368

merged 3 commits into from
Nov 10, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

This change fixes a panic introduced in #1355. The panic
occurred in cases where the provider attempted to set the
last applied config annotation with computed values.

Related issues (optional)

Fix #1365

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/354732087

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/354769733

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Nov 9, 2020

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/354780808

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone lblackstone marked this pull request as ready for review November 10, 2020 00:05
@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/354938797

@lblackstone
Fix panic with computed values on preview
a12cedc 
This change fixes a panic introduced in #1355. The panic
occurred in cases where the provider attempted to set the
last applied config annotation with computed values.
@lblackstone
Try again
fa5dad0
@lblackstone
Fix tests
c558bbe
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/356589544

@lblackstone lblackstone merged commit a12acca into master Nov 10, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/panic branch November 10, 2020 21:33
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

@EvanBoyle EvanBoyle Awaiting requested review from EvanBoyle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider previews causing panics
2 participants
@lblackstone @pgavlin