Remove deprecated helm/v2 SDK #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The helm/v2 SDK is deprecated, and is now being removed. The helm/v3 SDK provides equivalent support, but uses the helm client library rather than shelling out to the helm CLI. The v2:Chart and v3:Chart resources are already aliased, so users can update the SDK in code without a disruptive update.
lblackstone
force-pushed
the
lblackstone/drop-helmv2
branch
from
233dfff to
fb046fd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
Does the PR have any schema changes?Found 2 breaking changes: |
This comment was marked as outdated.
This comment was marked as outdated.
Does the PR have any schema changes?Found 2 breaking changes: |
thomas11
approved these changes
May 17, 2023
| @@ -182,13 +182,6 @@ func TestAccHelm(t *testing.T) { | |||
| } | |||
| } | |||
| }, | |||
| EditDirs: []integration.EditDir{ | |||
There was a problem hiding this comment.
Why do the two step2 disappear?
There was a problem hiding this comment.
Those tests were checking that the Chart could be created with the v2 SDK, and subsequently updated to v3. Since v2 is gone, the second step is no longer needed.
kpitzen
approved these changes
May 17, 2023
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
The helm/v2 SDK is deprecated, and is now being removed. The helm/v3 SDK provides equivalent support, but uses the helm client library rather than shelling out to the helm CLI. The v2:Chart and v3:Chart resources are already aliased, so users can update the SDK in code without a disruptive update.
lblackstone
added a commit
that referenced
this pull request
Jul 17, 2023
The helm/v2 SDK is deprecated, and is now being removed. The helm/v3 SDK provides equivalent support, but uses the helm client library rather than shelling out to the helm CLI. The v2:Chart and v3:Chart resources are already aliased, so users can update the SDK in code without a disruptive update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The helm/v2 SDK is deprecated, and is now being removed. The helm/v3 SDK provides equivalent support, but uses the helm client library rather than shelling out to the helm CLI. The v2:Chart and v3:Chart resources are already aliased, so users can update the SDK in code without a disruptive update.
Related issues (optional)
Fix #1789