Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native fetch, remove tmp dependency #3308

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Use native fetch, remove tmp dependency #3308

merged 4 commits into from
Nov 26, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Nov 11, 2024

Node 18 introduced native fetch. Pulumi already requires at least 18, so we can use this instead of node-fetch to resolve the punycode deprecation warning.

Also remove the tmp dependency which was only used in Helm v2 and removed in #2396.

Fixes #3301.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.08%. Comparing base (27bc9a1) to head (87f511b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/schema.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3308      +/-   ##
==========================================
+ Coverage   41.06%   41.08%   +0.01%     
==========================================
  Files          85       85              
  Lines       12740    12736       -4     
==========================================
  Hits         5232     5232              
+ Misses       7119     7115       -4     
  Partials      389      389              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blampe blampe changed the title Update node-fetch, remove tmp dependency Use native fetch, remove tmp dependency Nov 15, 2024
@blampe blampe requested review from rquitales and EronWright and removed request for rquitales November 15, 2024 23:28
@blampe blampe merged commit e369135 into master Nov 26, 2024
19 checks passed
@blampe blampe deleted the blampe/node-fetch branch November 26, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The punycode module is deprecated. Please use a userland alternative instead.
2 participants