Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detailed diff recordings to PF diff tests #2657

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Nov 22, 2024

This change adds recordings of the detailed diff sent to the engine to all Diff cross-tests in PF. This helps with spot-checking the results and troubleshooting issues.

This comes after #2629 in order to reduce the noise in the change there.

@VenelinMartinov
Copy link
Contributor Author

VenelinMartinov commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.45%. Comparing base (9319c4b) to head (630cd8b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2657   +/-   ##
=======================================
  Coverage   69.45%   69.45%           
=======================================
  Files         301      301           
  Lines       38626    38626           
=======================================
  Hits        26829    26829           
  Misses      10272    10272           
  Partials     1525     1525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from ede0755 to 3d3d520 Compare November 22, 2024 17:41
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from d03a954 to a3276b7 Compare November 22, 2024 17:41
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 3d3d520 to 1ef66c3 Compare November 22, 2024 18:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from a3276b7 to 04ad232 Compare November 22, 2024 18:22
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 04ad232 to 48cfafd Compare November 22, 2024 18:37
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 1ef66c3 to 8ba41dd Compare November 22, 2024 18:40
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 48cfafd to b397be8 Compare November 22, 2024 18:40
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 8ba41dd to 6b8c163 Compare November 22, 2024 19:18
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from b397be8 to d499e73 Compare November 22, 2024 19:18
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 6b8c163 to 8740ccb Compare November 22, 2024 19:45
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from d499e73 to cf04006 Compare November 22, 2024 19:45
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 8740ccb to 318058f Compare November 25, 2024 12:23
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from cf04006 to 58feb3f Compare November 25, 2024 12:24
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 318058f to f354cdb Compare November 25, 2024 12:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 58feb3f to 7b2664e Compare November 25, 2024 12:33
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from f354cdb to 8a0f428 Compare November 25, 2024 13:10
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 7b2664e to 9c825e7 Compare November 25, 2024 13:10
@t0yv0
Copy link
Member

t0yv0 commented Nov 25, 2024

Let's get the lint cleaned up I'll review tomorrow 🙏

@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 8a0f428 to 3291da2 Compare November 25, 2024 14:19
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 9c825e7 to 9b970f0 Compare November 25, 2024 14:19
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 9b970f0 to f090cc3 Compare November 25, 2024 14:28
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from 7258b95 to ca0b7a2 Compare November 25, 2024 15:24
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from f090cc3 to 711b272 Compare November 25, 2024 15:24
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from ca0b7a2 to f7072ac Compare November 25, 2024 16:51
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 711b272 to 8cc69e4 Compare November 25, 2024 16:51
@VenelinMartinov VenelinMartinov marked this pull request as draft November 25, 2024 17:32
@VenelinMartinov VenelinMartinov marked this pull request as ready for review November 25, 2024 17:32
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from f7072ac to a6a1abf Compare November 25, 2024 18:12
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 8cc69e4 to c9140dd Compare November 25, 2024 18:12
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from a6a1abf to ea8fb88 Compare November 26, 2024 10:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from c9140dd to 9dbcaab Compare November 26, 2024 10:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from ea8fb88 to e1a6d27 Compare November 26, 2024 11:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from 9dbcaab to f06789c Compare November 26, 2024 11:55
@VenelinMartinov VenelinMartinov force-pushed the vvm/detailed_diff_fix_secrets branch from e1a6d27 to 64d59f8 Compare November 26, 2024 11:56
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from f06789c to f769b76 Compare November 26, 2024 11:56
Base automatically changed from vvm/detailed_diff_fix_secrets to master November 26, 2024 12:48
@VenelinMartinov VenelinMartinov force-pushed the vvm/pf_diff_add_detailed_diff_recordings branch from f769b76 to 630cd8b Compare November 26, 2024 12:57
@VenelinMartinov VenelinMartinov enabled auto-merge (squash) November 26, 2024 12:57
@VenelinMartinov VenelinMartinov merged commit d7eacfb into master Nov 26, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_diff_add_detailed_diff_recordings branch November 26, 2024 16:02
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.97.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants