-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add detailed diff recordings to PF diff tests #2657
Add detailed diff recordings to PF diff tests #2657
Conversation
This change is part of the following stack: Change managed by git-spice. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2657 +/- ##
=======================================
Coverage 69.45% 69.45%
=======================================
Files 301 301
Lines 38626 38626
=======================================
Hits 26829 26829
Misses 10272 10272
Partials 1525 1525 ☔ View full report in Codecov by Sentry. |
ede0755
to
3d3d520
Compare
d03a954
to
a3276b7
Compare
3d3d520
to
1ef66c3
Compare
a3276b7
to
04ad232
Compare
04ad232
to
48cfafd
Compare
1ef66c3
to
8ba41dd
Compare
48cfafd
to
b397be8
Compare
8ba41dd
to
6b8c163
Compare
b397be8
to
d499e73
Compare
6b8c163
to
8740ccb
Compare
d499e73
to
cf04006
Compare
8740ccb
to
318058f
Compare
cf04006
to
58feb3f
Compare
318058f
to
f354cdb
Compare
58feb3f
to
7b2664e
Compare
f354cdb
to
8a0f428
Compare
7b2664e
to
9c825e7
Compare
Let's get the lint cleaned up I'll review tomorrow 🙏 |
8a0f428
to
3291da2
Compare
9c825e7
to
9b970f0
Compare
9b970f0
to
f090cc3
Compare
7258b95
to
ca0b7a2
Compare
f090cc3
to
711b272
Compare
ca0b7a2
to
f7072ac
Compare
711b272
to
8cc69e4
Compare
f7072ac
to
a6a1abf
Compare
8cc69e4
to
c9140dd
Compare
a6a1abf
to
ea8fb88
Compare
c9140dd
to
9dbcaab
Compare
ea8fb88
to
e1a6d27
Compare
9dbcaab
to
f06789c
Compare
e1a6d27
to
64d59f8
Compare
f06789c
to
f769b76
Compare
f769b76
to
630cd8b
Compare
This PR has been shipped in release v3.97.0. |
This change adds recordings of the detailed diff sent to the engine to all Diff cross-tests in PF. This helps with spot-checking the results and troubleshooting issues.
This comes after #2629 in order to reduce the noise in the change there.