SDKv2 Diff cross tests for replacement of computed properties #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Nov 25, 2024
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
ed5f954 to
78553dd
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
78553dd to
e78dbc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2666 +/- ##
=======================================
Coverage 69.44% 69.45%
=======================================
Files 301 301
Lines 38626 38626
=======================================
+ Hits 26824 26827 +3
+ Misses 10277 10275 -2
+ Partials 1525 1524 -1 ☔ View full report in Codecov by Sentry. |
VenelinMartinov
force-pushed
the
vvm/pf_diff_add_detailed_diff_recordings
branch
from
8cc69e4 to
c9140dd
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
e78dbc0 to
88f3e7a
Compare
VenelinMartinov
force-pushed
the
vvm/pf_diff_add_detailed_diff_recordings
branch
from
c9140dd to
9dbcaab
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
88f3e7a to
018d734
Compare
VenelinMartinov
force-pushed
the
vvm/pf_diff_add_detailed_diff_recordings
branch
from
9dbcaab to
f06789c
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
018d734 to
bc07e11
Compare
VenelinMartinov
force-pushed
the
vvm/pf_diff_add_detailed_diff_recordings
branch
from
f06789c to
f769b76
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
bc07e11 to
3f869cb
Compare
VenelinMartinov
force-pushed
the
vvm/pf_diff_add_detailed_diff_recordings
branch
from
f769b76 to
630cd8b
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
3f869cb to
1d232e8
Compare
Base automatically changed from
vvm/pf_diff_add_detailed_diff_recordings
to
master
November 26, 2024 16:02
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
1d232e8 to
4eeafda
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
4eeafda to
7f1830a
Compare
VenelinMartinov
force-pushed
the
vvm/sdkv2_diff_tests_computed_forcenew
branch
from
7f1830a to
43cc58d
Compare
iwahbe
approved these changes
Nov 27, 2024
|
This PR has been shipped in release v3.97.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Diff cross-tests for the SDKv2 bridge to test the re-computation of computed properties when the resource is marked for replacement. We display an incorrect preview in such cases in the PF and this also affects the SDKv2.
related to #2660