-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable_legacy_facts: true
includes deprecated puppet-lint-legacy_facts-check gem
#501
Comments
Hm. Looks like I linked the wrong PR for the merge of the legacy facts check into puppet-lint. I’m out of time right now, but I’ll try to track this down later. |
@danielparks Thanks! Really good catch. I will get this sorted! |
This change removes the template logic that adds `puppet-lint_legacy_facts-checl` based on `common:disable_legacy_facts` config and fixes #501. The legacy facts check is now part of puppet-lint which means including this gem is no longer required. Additionally, users that currently have `disable_legacy_facts` set to `true` in their `.sync` file may encounter breaking dependency conflicts.
(GH-501) Remove legacy facts gem
Hey @danielparks - A fix for this has been merged into main from #502, so I'll go ahead and close this issue. |
To avoid having to pull from main we will need to tag pdk-templates before it's properly available. |
Tagged pdk-templates @ 2.7.4 |
Describe the Bug
Enabling
disable_legacy_facts
creates a Gemfile that specifies contradictory version requirements. Specifically, it includes thepuppet-lint-legacy_facts-check gem and voxpupuli-puppet-lint-plugins
~> 4.0
. The voxpupuli gem requires puppet-lint~> 3.1
, but puppet-lint-legacy_facts-check is incompatible with that version.Note: puppet-lint-legacy_facts-check has been merged into puppet-lint (puppetlabs/puppet-lint#85, mmckinst/puppet-lint-legacy_facts-check#41), so the way this works probably needs to change regardless.
Expected Behavior
Setting
disable_legacy_facts
totrue
should result in a Gemfile that allows normal usage. Running lints should check for legacy facts.Steps to Reproduce
Environment
Tangentially related open PR: #460
The text was updated successfully, but these errors were encountered: