(CONT-339) Add top scope facts check #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
from
7ed7bf8 to
b4d4b5c
Compare
ekohl
reviewed
Feb 20, 2023
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
from
b4d4b5c to
41f69d3
Compare
chelnak
changed the title
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
from
41f69d3 to
95bc4ff
Compare
GSPatton
approved these changes
Feb 21, 2023
ekohl
reviewed
Feb 21, 2023
|
Yes good point. I can get that updated. With regards to your other comments:
|
bastelfreak
reviewed
Feb 23, 2023
bastelfreak
reviewed
Feb 23, 2023
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
4 times, most recently
from
7b1f025 to
f0cd1ec
Compare
bastelfreak
reviewed
Feb 23, 2023
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
from
f0cd1ec to
77b7e62
Compare
This commit introduces the top_scope_facts check. The plugin originated here: https://github.com/mmckinst/puppet-lint-top_scope_facts-check and was authored by @mmckinst and @seanmil. Permission has been given to migrate this check to puppet-lints default plugin set in this PR: mmckinst/puppet-lint-top_scope_facts-check#11
chelnak
force-pushed
the
CONT-339-add_top_scope_facts_check
branch
from
77b7e62 to
d416062
Compare
chelnak
requested review from
bastelfreak and
ekohl
and removed request for
ekohl
jordanbreen28
approved these changes
Feb 23, 2023
bastelfreak
approved these changes
Feb 23, 2023
But not me? ;) (I'm happy for my changes from mmckinst/puppet-lint-top_scope_facts-check#11 to be licensed as either MIT or Apache-2) |
|
Oh no! Sorry @alexjfisher. My bad. I can get this updated for you today. |
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 24, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3: puppetlabs/puppet-lint#85 We need to wait with merging this until puppet-lint 3.1 is released. This also depends on mmckinst/puppet-lint-legacy_facts-check#41
Nah, don't worry about it. It's in the merged commit message so what were you planning on updating anyway? :) |
|
#90 Adds you to the checks description 👍 |
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3: puppetlabs/puppet-lint#85 We need to wait with merging this until puppet-lint 3.1 is released. This also depends on mmckinst/puppet-lint-legacy_facts-check#41
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
bastelfreak
added a commit
to bastelfreak/voxpupuli-puppet-lint-plugins
that referenced
this pull request
Feb 28, 2023
puppet-lint-top_scope_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#85 puppet-lint-legacy_facts-check got vendored into puppet-lint 3.1: puppetlabs/puppet-lint#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the top_scope_facts check.
The plugin originated here:
https://github.com/mmckinst/puppet-lint-top_scope_facts-check
and was authored by @mmckinst and @seanmil.
Permission has been given to migrate this check to the puppet-lint default plugin set in this PR:
mmckinst/puppet-lint-top_scope_facts-check#11