Add fastcgi as vhost configuration option #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to the existing vhost modules the fastcgi module. Signed-off-by: Marc Koderer <m.koderer@telekom.de>
|
Can you add a rspec system test like dc91466 |
| @@ -0,0 +1,4 @@ | |||
| class apache::mod::fastcgi { | |||
| apache::mod { 'fastcgi': | |||
| package => 'libapache2-mod-fastcgi'} | |||
There was a problem hiding this comment.
The packagename should be in the params.pp file, then apache::mod { 'fastcgi' } will install it for you.
There was a problem hiding this comment.
Also if you know the name of the RedHat package you should add that to params as well.
|
Also please add some docs to the README about the new parameters. Thanks this PR is looking pretty good. |
|
Actually this PR duplicates some of the work in #295 Maybe you two can work together? |
|
Please rebase this. |
Merged
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to the existing vhost modules the fastcgi module.
Signed-off-by: Marc Koderer m.koderer@telekom.de