-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mod_fastcgi #390
mod_fastcgi #390
Conversation
Adds to the existing vhost modules the fastcgi module. Signed-off-by: Marc Koderer <m.koderer@telekom.de>
apache::mod { 'fastcgi': } | ||
|
||
if $fastcgi_lib_path { | ||
file { 'fastcgi.conf': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a template uses comment for the variables that its using. There are examples in the other mods.
$itk = undef, | ||
$fastcgi_server = undef, | ||
$fastcgi_socket = undef, | ||
$fastcgi_dir = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also document these three variables in the "template uses" comment above the vhost file resource? You can add a fastcgi fragment
section right here https://github.com/jlambert121/jbartko-apache/blob/be3e87e88e0697370a6f08466b8b35f62509659d/manifests/vhost.pp#L366-L367
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved.
Combining #295 and #325 which are similar but not identical. Rebased on current master, merge conflicts resolved, attempted to address all of the comments/requests for changes.