Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove add-from-bower #121

Closed
justinwoo opened this issue Jun 26, 2018 · 2 comments
Closed

Remove add-from-bower #121

justinwoo opened this issue Jun 26, 2018 · 2 comments
Labels
help wanted question

Comments

@justinwoo
Copy link
Collaborator

Even though I implemented this feature, I think it's proven to only confuse users into thinking they will get some kind of "extra-deps" behavior, and this really should exist as a separate tool that just uses bower-the-library (e.g. I have the beginnings of one here: https://github.com/justinwoo/get-package-def).

I've basically already implemented the core of what this is for my own package sets project anyhow with a simple Perl script: https://github.com/justinwoo/spacchetti/blob/c2a7cc4fdaadba2d09cb077fea2758e74e3f2818/prepare-bower.pl

So can we get to removing this? Is there anyone who actually likes add-from-bower and can speak for it?
@justinwoo
Copy link
Collaborator Author

In my Twitter poll I received only "yes, remove" votes

@justinwoo justinwoo mentioned this issue Jun 27, 2018
Merged
@justinwoo
Copy link
Collaborator Author

Fixed in #122

@justinwoo justinwoo mentioned this issue Jul 25, 2018
Merged
9 tasks
Profpatsch pushed a commit to justinwoo/nixpkgs that referenced this issue Jul 28, 2018
@justinwoo @Profpatsch
psc-package: 0.3.2 -> 0.4.1
eff76a6 
Updates that remove features and improve user experience.

Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch)
Filters "installing" messages for build (purescript/psc-package#130 by @Dretch)
Adds options for limiting jobs for install (purescript/psc-package#127 by @Vladciobanu)
Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
Profpatsch pushed a commit to NixOS/nixpkgs that referenced this issue Jul 28, 2018
@justinwoo @Profpatsch
psc-package: 0.3.2 -> 0.4.1
7dadfbd 
Updates that remove features and improve user experience.

Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch)
Filters "installing" messages for build (purescript/psc-package#130 by @Dretch)
Adds options for limiting jobs for install (purescript/psc-package#127 by @Vladciobanu)
Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinwoo