Only show "Installing n packages" when n > 1 (for issue #99) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are zero packages to install, show nothing. If there is only one package, then there is no need to provide an indication of how long it will take.
Dretch
changed the title
|
For issue #99 |
|
Cool, thanks! |
9 tasks
Profpatsch
pushed a commit
to justinwoo/nixpkgs
that referenced
this pull request
Jul 28, 2018
Updates that remove features and improve user experience. Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch) Filters "installing" messages for build (purescript/psc-package#130 by @Dretch) Adds options for limiting jobs for install (purescript/psc-package#127 by @Vladciobanu) Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
Profpatsch
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Jul 28, 2018
Updates that remove features and improve user experience. Adds warnings for trying to install packages without (purescript/psc-package#126 by @Dretch) Filters "installing" messages for build (purescript/psc-package#130 by @Dretch) Adds options for limiting jobs for install (purescript/psc-package#127 by @Vladciobanu) Per purescript/psc-package#121, removes the confusing misfeature "add-from-bower", which led to many users thinking this command was for adding "extra-deps" like Stack. See the thread for details on how you could readily replace this command if you used it before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are zero packages to install, show nothing. If there is only
one package, then there is no need to provide an indication of how
long it will take.