Skip to content

Commit

Permalink
[FIX] #4584: Dismiss feedback messages when modal is closed (#4588)
Browse files Browse the repository at this point in the history
fixes #4584 

Feedback messages were persisting when package modal was closed, added a
line to clear them out.
  • Loading branch information
zateutsch authored Jan 1, 2024
1 parent 2fa835d commit 2993f5b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion apps/pwabuilder/src/script/components/publish-pane.ts
Original file line number Diff line number Diff line change
Expand Up @@ -955,6 +955,7 @@ export class PublishPane extends LitElement {
if(e.target === dialog){
this.blob = undefined;
this.generating = false;
this.feedbackMessages = [];
await dialog!.hide();
recordPWABuilderProcessStep("publish_pane_closed", AnalyticsBehavior.ProcessCheckpoint);
document.body.style.height = "unset";
Expand Down Expand Up @@ -1049,7 +1050,7 @@ export class PublishPane extends LitElement {
class=${classMap({noX: this.preventClosing, dialog: true})}
@sl-hide=${(e: any) => this.hideDialog(e)}
@sl-request-close=${(e:any) => this.handleRequestClose(e)}
noHeader
noHeader
>
<div id="pp-frame-wrapper">
<div id="pp-frame-content">
Expand Down

0 comments on commit 2993f5b

Please sign in to comment.