Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #4584: Dismiss feedback messages when modal is closed #4588

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

zateutsch
Copy link
Contributor

fixes #4584

Feedback messages were persisting when package modal was closed, added a line to clear them out.

Copy link
Contributor

Thanks zateutsch for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4588.centralus.2.azurestaticapps.net

Copy link
Contributor

@jgw96 jgw96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgw96 jgw96 added this pull request to the merge queue Jan 1, 2024
Merged via the queue into staging with commit 2993f5b Jan 1, 2024
7 of 8 checks passed
@jgw96 jgw96 deleted the 4584-package-banner-bug branch January 1, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants