Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWA Builder]: No information is announced by the narrator after activating Next/Previous page button. #4254

Closed
Anshi0420 opened this issue Aug 10, 2023 · 8 comments
Closed

[PWA Builder]: No information is announced by the narrator after activating Next/Previous page button. #4254

Anshi0420 opened this issue Aug 10, 2023 · 8 comments
Assignees
@Jaylyn-Barbee
Labels
A11ySev3 Accessibility Team tag - P3 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web

Comments

@Anshi0420
Copy link
Collaborator

Anshi0420 commented Aug 10, 2023 •
edited
Loading

What happened?

After activating next/previous button no information is announced by the narrator, narrator remains silent.

How do we reproduce the behavior?

Repro Steps:

  1. Open the PWA Builder URL in Anaheim dev browser.
  2. PWA Builder page will appear.
  3. Turn on the narrato using Win + Ctrl + Enter.
  4. Now Navigate to the Next/Previous buttons present in Action section.
  5. Activate the next button.
  6. Observe the narrator's announcement.

What do you expect to happen?

After activating next/previous button either information such as page 2 of 2 must be announced or whole information present in the div must be announce by the narrator.

What environment were you using?

Test Environment:
OS Build: Windows 11 Enterprise Insider Preview 22H2 (23493.1000)
Edge Browser: Version 115.0.1880.3 (Official build) dev (64-bit)
User ID: V-
URL: https://www.pwabuilder.com/reportcard?site=https://webboard.app
Screen Reader: Narrator

Additional context

Observation:
Issue is also repro with NVDA.

User Experience:
If the no information is announced by the narrator after activating next button of the page, then the screen reader users will not get the information of the page and they may get confused.

WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Attachments:

2023-08-10.16-13-50.mp4
@Anshi0420 Anshi0420 added bug 🐛 needs triage 🔍 A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft A11ySev3 Accessibility Team tag - P3 items Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team HCL-E+D CT-July23 labels Aug 10, 2023
@Suriya617 Suriya617 mentioned this issue Aug 17, 2023
Closed
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

2 similar comments
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Jaylyn-Barbee Jaylyn-Barbee changed the title [PWA Builder-Blog]: No information is announced by the narrator after activating Next/Previous page button. [PWA Builder]: No information is announced by the narrator after activating Next/Previous page button. Aug 28, 2023
@Jaylyn-Barbee Jaylyn-Barbee self-assigned this Aug 29, 2023
@Jaylyn-Barbee Jaylyn-Barbee mentioned this issue Aug 30, 2023
Merged
3 tasks
@Jaylyn-Barbee Jaylyn-Barbee moved this to In Review 🤔 in PWABuilder Aug 30, 2023
github-merge-queue bot pushed a commit that referenced this issue Aug 30, 2023
@Jaylyn-Barbee
[Accessibility] Updates to the action items prev and next buttons (#4334
a0496cc 
)

fixes #4254 and #4233
<!-- Link to relevant issue (for ex: "fixes #1234") which will
automatically close the issue once the PR is merged -->

## PR Type
<!-- Please uncomment one ore more that apply to this PR -->

Bugfix 
<!-- - Feature -->
<!-- - Code style update (formatting) -->
<!-- - Refactoring (no functional changes, no api changes) -->
<!-- - Build or CI related changes -->
<!-- - Documentation content changes -->
<!-- - Sample app changes -->
<!-- - Other... Please describe: -->


## Describe the current behavior?
<!-- Please describe the current behavior that is being modified or link
to a relevant issue. -->
1. Buttons didn't have a name or label
2. Buttons didn't have audio feedback when clicked and using narrator

## Describe the new behavior?
1. Buttons named 
2. Buttons announce the page number when clicked in narrator.

## PR Checklist
- [x] Test: run `npm run test` and ensure that all tests pass
- [x] Target main branch (or an appropriate release branch if
appropriate for a bug fix)
- [x] Ensure that your contribution follows [standard accessibility
guidelines](https://docs.microsoft.com/en-us/microsoft-edge/accessibility/design).
Use tools like https://webhint.io/ to validate your changes.

## Additional Information
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@github-project-automation github-project-automation bot moved this from In Review 🤔 to Done ✔️ in PWABuilder Sep 21, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as "needs attention 👋" since it has not been triaged for 7 days. Please triage the issue .

@Anshi0420
Copy link
Collaborator Author

Closing this bug as it is fixed.

@Anshi0420 Anshi0420 added the A11yTTValidated Accessibility team tag for closed bugs label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jaylyn-Barbee Jaylyn-Barbee

Labels
A11ySev3 Accessibility Team tag - P3 items A11yTTValidated Accessibility team tag for closed bugs A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Accessibility [E+D] Issues found by the accessibility E+D Team at Microsoft bug 🐛 CT-July23 HCL-E+D needs attention 👋 needs triage 🔍 Product-PWABuilder For Tracking PWABuilder bugs by Accessibility E+D team PWABuilder_Web
Projects
PWABuilder
Status: Done ✔️
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Jaylyn-Barbee @Suriya617 @Anshi0420