Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Updates to the action items prev and next buttons #4334

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

Jaylyn-Barbee
Copy link
Contributor

fixes #4254 and #4233

PR Type

Bugfix

Describe the current behavior?

  1. Buttons didn't have a name or label
  2. Buttons didn't have audio feedback when clicked and using narrator

Describe the new behavior?

  1. Buttons named
  2. Buttons announce the page number when clicked in narrator.

PR Checklist

  • Test: run npm run test and ensure that all tests pass
  • Target main branch (or an appropriate release branch if appropriate for a bug fix)
  • Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@Jaylyn-Barbee Jaylyn-Barbee changed the title accessibility updates to the action items prev and next buttons [Accessibility] Updates to the action items prev and next buttons Aug 30, 2023
@microsoft-github-policy-service
Copy link
Contributor

Thanks Jaylyn-Barbee for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@Jaylyn-Barbee Jaylyn-Barbee added this pull request to the merge queue Aug 30, 2023
Merged via the queue into staging with commit a0496cc Aug 30, 2023
@Jaylyn-Barbee Jaylyn-Barbee deleted the jay/prev-next branch August 30, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants