Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROB: Widths def in cmap calls indirectObject #1719

Merged
merged 1 commit into from
Mar 17, 2023
Merged

ROB: Widths def in cmap calls indirectObject #1719

merged 1 commit into from
Mar 17, 2023

Conversation

pubpub-zz
Copy link
Collaborator

Fixes #1718

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9878034) 92.50% compared to head (a56ff98) 92.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1719   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files          34       34           
  Lines        6512     6512           
  Branches     1286     1286           
=======================================
  Hits         6024     6024           
  Misses        316      316           
  Partials      172      172
Impacted Files Coverage Δ
pypdf/_cmap.py 95.25% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pubpub-zz
Copy link
Collaborator Author

all yours 😉

@MartinThoma MartinThoma merged commit 3419429 into py-pdf:main Mar 17, 2023
MartinThoma added a commit that referenced this pull request Mar 18, 2023
@MartinThoma
REL: 3.6.0
e34088e 
New Features (ENH)
-  Extend PdfWriter.append() to PageObjects (#1704)
-  Support qualified names in update_page_form_field_values (#1695)

Robustness (ROB)
-  Tolerate streams without length field (#1717)
-  Accept DictionaryObject in /D of NamedDestination (#1720)
-  Widths def in cmap calls IndirectObject (#1719)
@pubpub-zz pubpub-zz deleted the WidthObjects branch June 24, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown widths when reading PDFs?
2 participants
@pubpub-zz @MartinThoma