ROB: Accept DictionaryObject in /D of NamedDestination #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in accordance with §2 page 584 fixes py-pdf#1710
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1720 +/- ##
=======================================
Coverage 92.50% 92.50%
=======================================
Files 34 34
Lines 6512 6514 +2
Branches 1286 1287 +1
=======================================
+ Hits 6024 6026 +2
Misses 316 316
Partials 172 172
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MartinThoma
changed the title
|
@pubpub-zz That was the PR where I was wondering ... is it mine? 😄 |
|
It's all yours 🤣 |
MartinThoma
added a commit
that referenced
this pull request
Mar 18, 2023
New Features (ENH) - Extend PdfWriter.append() to PageObjects (#1704) - Support qualified names in update_page_form_field_values (#1695) Robustness (ROB) - Tolerate streams without length field (#1717) - Accept DictionaryObject in /D of NamedDestination (#1720) - Widths def in cmap calls IndirectObject (#1719)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accepts destination stored in "/D" of a dictionaryObject in accordance with §2 page 584
fixes #1710